From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/4] x86/cpu: Introduce INTEL_CPU_FAM*_NODATA() helper macros
Date: Fri, 31 Aug 2018 18:51:04 +0300 [thread overview]
Message-ID: <20180831155104.GZ11447@smile.fi.intel.com> (raw)
In-Reply-To: <87mut2pmqf.fsf@linux.intel.com>
On Fri, Aug 31, 2018 at 08:41:28AM -0700, Andi Kleen wrote:
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> > +
> > +#define INTEL_CPU_FAM_ANY_NODATA(_family, _model) \
> > + INTEL_CPU_FAM_ANY(_family, _model, NULL)
> > +
> > +#define INTEL_CPU_FAM6_NODATA(_model) \
> > + INTEL_CPU_FAM_ANY_NODATA(6, INTEL_FAM6_##_model)
> _NODATA is actually longer than passing NULL ?
One character longer (you have to compare to ", NULL").
> Seems unnecessary
Let's gather other's opinions.
P.S. In any case some refactoring is needed to allow NULL in parameters (move &
out from base macro).
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2018-08-31 15:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 9:10 [PATCH v1 1/4] x86/cpu: Introduce INTEL_CPU_FAM*_NODATA() helper macros Andy Shevchenko
2018-08-31 9:10 ` [PATCH v1 2/4] x86/efi: Get rid of custom ICPU() macro Andy Shevchenko
2018-09-04 15:34 ` kbuild test robot
2018-08-31 9:10 ` [PATCH v1 3/4] ACPI / LPSS: " Andy Shevchenko
2018-09-11 11:02 ` Rafael J. Wysocki
2018-08-31 9:10 ` [PATCH v1 4/4] ACPI / x86: utils: " Andy Shevchenko
2018-09-11 11:03 ` Rafael J. Wysocki
2018-08-31 15:41 ` [PATCH v1 1/4] x86/cpu: Introduce INTEL_CPU_FAM*_NODATA() helper macros Andi Kleen
2018-08-31 15:51 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180831155104.GZ11447@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).