From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Busch Subject: Re: [PATCH 0/3] acpi, nfit: Add dirty shutdown count to sysfs Date: Thu, 27 Sep 2018 09:21:40 -0600 Message-ID: <20180927152140.GA19589@localhost.localdomain> References: <153802226065.833068.11943510429252969385.stgit@dwillia2-desk3.amr.corp.intel.com> <20180927071135.GB6959@linux-x5ow.site> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180927071135.GB6959-qw2SdCWA0PpjqqEj2zc+bA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Johannes Thumshirn Cc: linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org List-Id: linux-acpi@vger.kernel.org On Thu, Sep 27, 2018 at 09:11:35AM +0200, Johannes Thumshirn wrote: > On Wed, Sep 26, 2018 at 09:24:20PM -0700, Dan Williams wrote: > > The Intel NVDIMM command specification publishes a dirty-shutdown-count > > in addition to the dirty-shutdown / flush-failed indication that comes > > from the ACPI NFIT. This is expected to be a common property of NVDIMMs > > and is a static hardware health detail to be cached / exported via > > sysfs. > > > > Add plumbing for retrieving this data at driver load time, publish the > > count, and use the dynamically retrieved dirty-shutdown indicator to > > augment the existing 'flush_failed' flag. > > Is this the same thing as the LSS Latch stuff that went into ndctl? On a related note, the ndctl latch implementation doesn't satisfy all the needs, so I expect it'll be reverted https://lists.01.org/pipermail/linux-nvdimm/2018-September/017892.html