From: Keith Busch <keith.busch-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org
Subject: Re: [PATCH 3/3] tools/testing/nvdimm: Populate dirty shutdown data
Date: Thu, 27 Sep 2018 13:37:12 -0600 [thread overview]
Message-ID: <20180927193711.GF19589@localhost.localdomain> (raw)
In-Reply-To: <153802227683.833068.14067072355792705345.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Wed, Sep 26, 2018 at 09:24:36PM -0700, Dan Williams wrote:
> +/* strong / override definition of nfit_intel_shutdown_status */
> +void nfit_intel_shutdown_status(struct nfit_mem *nfit_mem)
> +{
> + set_bit(NFIT_MEM_DIRTY_COUNT, &nfit_mem->flags);
> + nfit_mem->dirty_shutdown = 42;
> +}
That's a lot of dirty shutdowns! Better bring a towel.
Reviewed-by: Keith Busch <keith.busch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
next prev parent reply other threads:[~2018-09-27 19:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 4:24 [PATCH 0/3] acpi, nfit: Add dirty shutdown count to sysfs Dan Williams
[not found] ` <153802226065.833068.11943510429252969385.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-09-27 4:24 ` [PATCH 1/3] acpi, nfit: Introduce nfit_mem flags Dan Williams
[not found] ` <153802226609.833068.13167424056547725578.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-09-27 19:37 ` Keith Busch
2018-09-27 4:24 ` [PATCH 2/3] acpi, nfit: Collect shutdown status Dan Williams
[not found] ` <153802227150.833068.16202031710309659911.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-09-27 19:37 ` Keith Busch
2018-09-27 4:24 ` [PATCH 3/3] tools/testing/nvdimm: Populate dirty shutdown data Dan Williams
[not found] ` <153802227683.833068.14067072355792705345.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-09-27 19:37 ` Keith Busch [this message]
2018-09-27 7:11 ` [PATCH 0/3] acpi, nfit: Add dirty shutdown count to sysfs Johannes Thumshirn
[not found] ` <20180927071135.GB6959-qw2SdCWA0PpjqqEj2zc+bA@public.gmane.org>
2018-09-27 15:21 ` Keith Busch
2018-09-27 15:33 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927193711.GF19589@localhost.localdomain \
--to=keith.busch-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).