From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v4 1/2] drivers: base: cacheinfo: Do not populate sysfs for unknown cache types Date: Thu, 4 Oct 2018 08:41:39 -0700 Message-ID: <20181004154139.GA6921@kroah.com> References: <1538666406-7504-1-git-send-email-jhugo@codeaurora.org> <1538666406-7504-2-git-send-email-jhugo@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1538666406-7504-2-git-send-email-jhugo@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Jeffrey Hugo Cc: sudeep.holla@arm.com, rjw@rjwysocki.net, linux-acpi@vger.kernel.org, jeremy.linton@arm.com, linux-kernel@vger.kernel.org, vkilari@codeaurora.org List-Id: linux-acpi@vger.kernel.org On Thu, Oct 04, 2018 at 09:20:05AM -0600, Jeffrey Hugo wrote: > If a cache has an unknown type because neither the hardware nor the > firmware told us, an entry in the sysfs tree will be made, but the type > file will not be present. lscpu depends on the type file being present > for every entry, and will error out without printing system information > if lscpu cannot open the type file. > > Presenting information about a cache without indicating its type is not > useful, therefore if we hit a cache with an unknown type, stop populating > sysfs so that userspace has the maximum amount of useful information. > > This addresses the following lscpu error, which prevents any output. > lscpu: cannot open /sys/devices/system/cpu/cpu0/cache/index3/type: No such > file or directory > > Suggested-by: Sudeep Holla > Signed-off-by: Jeffrey Hugo > Reviewed-by: Jeremy Linton > Reviewed-by: Sudeep Holla > --- > drivers/base/cacheinfo.c | 2 ++ > 1 file changed, 2 insertions(+) Acked-by: Greg Kroah-Hartman