Re: [PATCH v2 15/23] ACPI: use proper DYNAMIC_DEBUG_BRANCH macro

Rafael J. Wysocki
2018-10-10T09:38:29Z

On Tue, Oct 9, 2018 at 1:21 PM Rasmus Villemoes
<linux@rasmusvillemoes.dk> wrote:
>
> dynamic debug may be implemented via static keys, but ACPI is missing
> out on that runtime benefit since it open-codes one possible definition
> of DYNAMIC_DEBUG_BRANCH.
>
> Cc: linux-acpi@vger.kernel.org
> Acked-by: Jason Baron <jbaron@akamai.com>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

> ---
> include/linux/acpi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index de8d3d3fa651..21e03aa32aae 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -982,7 +982,7 @@ void __acpi_handle_debug(struct _ddebug *descriptor, acpi_handle handle, const c
> #define acpi_handle_debug(handle, fmt, ...) \
> do { \
> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
> - if (unlikely(descriptor.flags & _DPRINTK_FLAGS_PRINT)) \
> + if (DYNAMIC_DEBUG_BRANCH(descriptor)) \
> __acpi_handle_debug(&descriptor, handle, pr_fmt(fmt), \
> ##__VA_ARGS__); \
> } while (0)
> --
> 2.19.1.3.g1d92a00e68
>