From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [RFC PATCH 0/5] device property: Introducing software nodes
Date: Wed, 17 Oct 2018 18:06:43 -0700 [thread overview]
Message-ID: <20181018010643.GB205061@dtor-ws> (raw)
In-Reply-To: <20181017133612.GK24771@kuha.fi.intel.com>
Hi Heikki,
On Wed, Oct 17, 2018 at 04:36:12PM +0300, Heikki Krogerus wrote:
> @@ -189,7 +210,7 @@ static int cht_int33fe_probe(struct i2c_client *client)
> memset(&board_info, 0, sizeof(board_info));
> strlcpy(board_info.type, "typec_fusb302", I2C_NAME_SIZE);
> board_info.dev_name = "fusb302";
> - board_info.properties = fusb302_props;
> + board_info.fwnode = data->fusb302_node;
> board_info.irq = fusb302_irq;
>
> data->fusb302 = i2c_acpi_new_device(dev, 2, &board_info);
OK, this totally explains it. I forgot how we can supply the properties
in board info for I2C/SPI devices and they would get attached to a
device later, and this obviously does not work if one wants to attach a
sub-tree.
Thank you for providing this example.
--
Dmitry
prev parent reply other threads:[~2018-10-18 1:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 11:39 [RFC PATCH 0/5] device property: Introducing software nodes Heikki Krogerus
2018-10-12 11:39 ` [RFC PATCH 1/5] drivers core: Prepare support for multiple platform notifications Heikki Krogerus
2018-10-12 11:39 ` [RFC PATCH 2/5] ACPI / glue: Add acpi_platform_notify() function Heikki Krogerus
2018-10-12 11:39 ` [RFC PATCH 3/5] drivers: base: Introducing software nodes to the firmware node framework Heikki Krogerus
2018-10-16 12:57 ` Andy Shevchenko
2018-10-16 14:53 ` Heikki Krogerus
2018-10-12 11:39 ` [RFC PATCH 4/5] device property: Move device_add_properties() to swnode.c Heikki Krogerus
2018-10-12 11:39 ` [RFC PATCH 5/5] device property: Remove struct property_set Heikki Krogerus
2018-10-16 7:35 ` [RFC PATCH 0/5] device property: Introducing software nodes Linus Walleij
2018-10-16 7:36 ` Rafael J. Wysocki
2018-10-16 8:40 ` Heikki Krogerus
2018-10-16 8:44 ` Rafael J. Wysocki
2018-10-16 14:35 ` Andy Shevchenko
2018-10-16 14:46 ` Heikki Krogerus
2018-10-17 14:53 ` Heikki Krogerus
2018-10-16 17:32 ` Dmitry Torokhov
2018-10-17 13:36 ` Heikki Krogerus
2018-10-18 1:06 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018010643.GB205061@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).