Re: [PATCH v9 2/8] x86/boot: Copy kstrtoull() to compressed period

Baoquan He
2018-10-18T06:01:28Z

On 10/18/18 at 01:51pm, Chao Fan wrote:
> On Thu, Oct 18, 2018 at 12:03:38PM +0800, Baoquan He wrote:
> >On 10/17/18 at 06:20pm, Chao Fan wrote:
> >> Copy kstrtoull() to 'compressed' directory so that
> >> we can use it to change the address in cmdline from
> >> string to unsigned long long.
> >
> >So you don't like simple_strtoull() in arch/x86/boot/string.c which has
> >been used in boot/compressed/kaslr.c . Why? Are you going to clean up
> >simple_strtoull()?
>
> Boris told me use the new function in old version's review.
> Both work well for me.

OK, then maybe you can clear simple_strtoull() out in a separate patch
since you have introduced a new one. Or after this patchset.