From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Mario.Limonciello@dell.com
Cc: mika.westerberg@linux.intel.com, lukas@wunner.de,
iommu@lists.linux-foundation.org, joro@8bytes.org,
dwmw2@infradead.org, baolu.lu@linux.intel.com,
ashok.raj@intel.com, bhelgaas@google.com, rjw@rjwysocki.net,
jacob.jun.pan@intel.com, andreas.noever@gmail.com,
michael.jamet@intel.com, YehezkelShB@gmail.com,
ckellner@redhat.com, anthony.wong@canonical.com,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] PCI / ACPI: Identify external PCI devices
Date: Fri, 16 Nov 2018 10:57:38 +0000 [thread overview]
Message-ID: <20181116105738.GA21277@red-moon> (raw)
In-Reply-To: <372db397d5384efd8e7264ba8e1b9cbd@ausx13mpc120.AMER.DELL.COM>
On Thu, Nov 15, 2018 at 07:33:54PM +0000, Mario.Limonciello@dell.com wrote:
>
>
> > -----Original Message-----
> > From: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Sent: Thursday, November 15, 2018 1:01 PM
> > To: Lorenzo Pieralisi
> > Cc: Lukas Wunner; iommu@lists.linux-foundation.org; Joerg Roedel; David
> > Woodhouse; Lu Baolu; Ashok Raj; Bjorn Helgaas; Rafael J. Wysocki; Jacob jun Pan;
> > Andreas Noever; Michael Jamet; Yehezkel Bernat; Christian Kellner; Limonciello,
> > Mario; Anthony Wong; linux-acpi@vger.kernel.org; linux-pci@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [PATCH 1/4] PCI / ACPI: Identify external PCI devices
> >
> >
> > [EXTERNAL EMAIL]
> >
> > On Thu, Nov 15, 2018 at 05:46:08PM +0000, Lorenzo Pieralisi wrote:
> > > Do you really need to parse it if the dev->is_thunderbolt check is enough ?
> >
> > Yes, we need to parse it one way or another. dev->is_thunderbolt is
> > based on heuristics which do not apply anymore when the thing gets
> > integrated in the SoC.
> >
> > The _DSD is there already (on existing systems) and is being used by
> > Windows so I don't understand why we cannot take advantage of it? Every
> > new system with Thunderbolt ports will have it.
We have different opinions on this, there is no point in me reiterating
it over and over, I am against the approach taken to solve this problem
first in defining the bindings outside the ACPI specifications and
second by acquiescing to what has been done so that it will be done
over and over again.
I will raise the point in the appropriate forum, it is up to Bjorn
and Rafael to decide on this patch.
Lorenzo
next prev parent reply other threads:[~2018-11-16 10:57 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 16:06 [PATCH 0/4] PCI / iommu / thunderbolt: IOMMU based DMA protection Mika Westerberg
[not found] ` <20181112160628.86620-1-mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-11-12 16:06 ` [PATCH 1/4] PCI / ACPI: Identify external PCI devices Mika Westerberg
2018-11-12 18:02 ` Lukas Wunner
[not found] ` <20181112180203.lx72gjfplb6xlur7-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2018-11-13 10:56 ` Lorenzo Pieralisi
2018-11-13 11:27 ` Mika Westerberg
[not found] ` <20181113112700.GT2500-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2018-11-13 11:45 ` Lorenzo Pieralisi
2018-11-15 10:22 ` Mika Westerberg
2018-11-15 11:13 ` Lorenzo Pieralisi
[not found] ` <20181115111356.GA599-4tUPXFaYRHv6sAKXYmQ0tx/iLCjYCKR+VpNB7YpNyf8@public.gmane.org>
2018-11-15 11:37 ` Mika Westerberg
2018-11-15 12:07 ` Lukas Wunner
2018-11-15 12:16 ` Mika Westerberg
2018-11-15 17:46 ` Lorenzo Pieralisi
2018-11-15 17:58 ` Yehezkel Bernat
2018-11-15 19:10 ` Mika Westerberg
2018-11-15 19:27 ` Lukas Wunner
2018-11-15 19:32 ` Mika Westerberg
2018-11-16 9:18 ` Christoph Hellwig
2018-11-16 9:32 ` Mika Westerberg
2018-11-22 10:48 ` Mika Westerberg
2018-11-22 10:59 ` Christoph Hellwig
2018-11-15 19:00 ` Mika Westerberg
2018-11-15 19:33 ` Mario.Limonciello
2018-11-16 10:57 ` Lorenzo Pieralisi [this message]
2018-11-20 21:43 ` Rafael J. Wysocki
2018-11-21 12:40 ` Lorenzo Pieralisi
2018-11-16 7:01 ` Mika Westerberg
2018-11-12 16:06 ` [PATCH 2/4] iommu/vt-d: Force IOMMU on for platform opt in hint Mika Westerberg
2018-11-12 17:49 ` Raj, Ashok
2018-11-12 18:09 ` Alex Williamson
2018-11-12 19:51 ` Raj, Ashok
2018-11-12 16:06 ` [PATCH 3/4] iommu/vt-d: Do not enable ATS for external devices Mika Westerberg
2018-11-12 17:53 ` Raj, Ashok
2018-11-12 16:06 ` [PATCH 4/4] thunderbolt: Export IOMMU based DMA protection support to userspace Mika Westerberg
2018-11-12 16:22 ` Mario.Limonciello
2018-11-13 10:36 ` Mika Westerberg
2018-11-12 16:59 ` Yehezkel Bernat
2018-11-13 10:55 ` Mika Westerberg
2018-11-13 11:13 ` Yehezkel Bernat
2018-11-13 11:40 ` Mika Westerberg
2018-11-13 14:42 ` Yehezkel Bernat
[not found] ` <CA+CmpXt1cfqjz94=WsggKpNCUw3761-cewa_HTa0ETcYK7o+Hw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-11-13 15:20 ` Mika Westerberg
[not found] ` <20181113152038.GD2500-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2018-11-13 15:38 ` Yehezkel Bernat
[not found] ` <CA+CmpXteN1PJEHMV8rvfeBXK6Eb4z6BgZwa8Ojavi1y9pKN-jA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-11-13 16:12 ` Mika Westerberg
2018-11-12 18:12 ` [PATCH 0/4] PCI / iommu / thunderbolt: IOMMU based DMA protection Lukas Wunner
[not found] ` <20181112181214.xaahc5wni4vuwl6h-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2018-11-12 19:04 ` Yehezkel Bernat
2018-11-13 11:13 ` Mika Westerberg
2018-11-13 8:54 ` Joerg Roedel
2018-11-13 11:32 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116105738.GA21277@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=Mario.Limonciello@dell.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=anthony.wong@canonical.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=ckellner@redhat.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=joro@8bytes.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).