From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 05/13] i2c: acpi: Return error pointers from i2c_acpi_new_device() Date: Tue, 27 Nov 2018 17:40:12 +0200 Message-ID: <20181127154012.GX10650@smile.fi.intel.com> References: <20181126150858.16901-1-andriy.shevchenko@linux.intel.com> <20181126150858.16901-6-andriy.shevchenko@linux.intel.com> <20181127090432.GK2296@lahna.fi.intel.com> <98674437-9374-32d4-4b25-dedd0cad5bea@redhat.com> <20181127114953.GQ2296@lahna.fi.intel.com> <20181127134623.GR10650@smile.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Hans de Goede Cc: Mika Westerberg , Darren Hart , platform-driver-x86@vger.kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, Jonathan Cameron , Wolfram Sang , linux-i2c@vger.kernel.org, Heikki Krogerus , linux-kernel@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On Tue, Nov 27, 2018 at 04:24:41PM +0100, Hans de Goede wrote: > On 27-11-18 14:46, Andy Shevchenko wrote: > > On Tue, Nov 27, 2018 at 01:49:53PM +0200, Mika Westerberg wrote: > > > On Tue, Nov 27, 2018 at 10:16:25AM +0100, Hans de Goede wrote: > > > > One problem is that i2c_new_device() currently simply returns NULL on all > > > > errors. Andy, you could take a look how much work it is to make that return > > > > an ERR_PTR too, or just check its return value and return ERR_PTR(-ENXIO) if > > > > it fails for now... > > > > > > I would use -ENODEV here and -EINVAL in case there is no ACPI companion :) > > > > Sounds more traditional than ENXIO. > > I would go the way Mika proposed if there is no objection. > > Works for me, go for it. Just sent a new version, but dropped your Rb in that very patch. Please, check if everything is okay. -- With Best Regards, Andy Shevchenko