Re: [PATCH RFCv2 2/4] mm/memory_hotplug: Replace "bool want_memblock" by "int type"

David Hildenbrand
2018-12-03T10:33:12Z

On 01.12.18 02:50, Wei Yang wrote:
> On Fri, Nov 30, 2018 at 06:59:20PM +0100, David Hildenbrand wrote:
>> Let's pass a memory block type instead. Pass "MEMORY_BLOCK_NONE" for device
>> memory and for now "MEMORY_BLOCK_UNSPECIFIED" for anything else. No
>> functional change.
>
> I would suggest to put more words to this.

Sure, makes sense, I'll add more details. Thanks!

>
> "
> Function arch_add_memory()'s last parameter *want_memblock* is used to
> determin whether it is necessary to create a corresponding memory block
> device. After introducing the memory block type, this patch replaces the
> bool type *want_memblock* with memory block type with following rules
> for now:
>
> * Pass "MEMORY_BLOCK_NONE" for device memory
> * Pass "MEMORY_BLOCK_UNSPECIFIED" for anything else
>
> Since this parameter is passed deep to __add_section(), all its
> descendents are effected. Below lists those descendents.
>
> arch_add_memory()
> add_pages()
> __add_pages()
> __add_section()
>
> "

[...]

--

Thanks,

David / dhildenb