From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal =?UTF-8?B?U3VjaMOhbmVr?= Subject: Re: [PATCH RFCv2 3/4] mm/memory_hotplug: Introduce and use more memory types Date: Tue, 4 Dec 2018 10:44:54 +0100 Message-ID: <20181204104454.522a3ba2@naga.suse.cz> References: <20181130175922.10425-1-david@redhat.com> <20181130175922.10425-4-david@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20181130175922.10425-4-david@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: David Hildenbrand Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-acpi@vger.kernel.org, devel@linuxdriverproject.org, xen-devel@lists.xenproject.org, x86@kernel.org, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Martin Schwidefsky , Heiko Carstens , Boris Ostrovsky List-Id: linux-acpi@vger.kernel.org On Fri, 30 Nov 2018 18:59:21 +0100 David Hildenbrand wrote: > Let's introduce new types for different kinds of memory blocks and use > them in existing code. As I don't see an easy way to split this up, > do it in one hunk for now. > > acpi: > Use DIMM or DIMM_UNREMOVABLE depending on hotremove support in the kernel. > Properly change the type when trying to add memory that was already > detected and used during boot (so this memory will correctly end up as > "acpi" in user space). > > pseries: > Use DIMM or DIMM_UNREMOVABLE depending on hotremove support in the kernel. > As far as I see, handling like in the acpi case for existing blocks is > not required. > > probed memory from user space: > Use DIMM_UNREMOVABLE as there is no interface to get rid of this code > again. > > hv_balloon,xen/balloon: > Use BALLOON. As simple as that :) > > s390x/sclp: > Use a dedicated type S390X_STANDBY as this type of memory and it's > semantics are very s390x specific. > > powernv/memtrace: > Only allow to use BOOT memory for memtrace. I consider this code in > general dangerous, but we have to keep it working ... most probably just > a debug feature. I don't think it should be arbitrarily restricted like that. Thanks Michal