From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v7 02/25] ACPI / APEI: Remove silent flag from ghes_read_estatus() Date: Tue, 4 Dec 2018 12:36:01 +0100 Message-ID: <20181204113601.GB11803@zn.tnic> References: <20181203180613.228133-1-james.morse@arm.com> <20181203180613.228133-3-james.morse@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20181203180613.228133-3-james.morse@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: James Morse Cc: Rafael Wysocki , Tony Luck , Fan Wu , linux-mm@kvack.org, Marc Zyngier , Catalin Marinas , Will Deacon , Dongjiu Geng , linux-acpi@vger.kernel.org, Naoya Horiguchi , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Len Brown List-Id: linux-acpi@vger.kernel.org On Mon, Dec 03, 2018 at 06:05:50PM +0000, James Morse wrote: > Subsequent patches will split up ghes_read_estatus(), at which > point passing around the 'silent' flag gets annoying. This is to > suppress prink() messages, which prior to commit 42a0bb3f7138 > ("printk/nmi: generic solution for safe printk in NMI"), were > unsafe in NMI context. > > This is no longer necessary, remove the flag. printk() messages > are batched in a per-cpu buffer and printed via irq-work, or a call > back from panic(). > > Signed-off-by: James Morse > --- > Changes since v6: > * Moved earlier in the series, > * Tinkered with the commit message. > * switched to pr_warn_ratelimited() to shut checkpatch up > > shutup checkpatch > --- > drivers/acpi/apei/ghes.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.