From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH] x86/kernel: Fix more -Wmissing-prototypes warnings Date: Wed, 5 Dec 2018 15:24:48 +0100 Message-ID: <20181205142448.GH29510@zn.tnic> References: <20181205101131.28996-1-bp@alien8.de> <20181205224906.824483ea3c5d1d5b7712c99a@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20181205224906.824483ea3c5d1d5b7712c99a@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Masami Hiramatsu Cc: LKML , Andrew Banman , Dimitri Sivanich , "H. Peter Anvin" , Ingo Molnar , Mike Travis , "Steven Rostedt (VMware)" , Thomas Gleixner , Yi Wang , linux-acpi@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On Wed, Dec 05, 2018 at 10:49:06PM +0900, Masami Hiramatsu wrote: > I would like to put this prototype inside arch/x86/kernel/kprobes/core.c, > since that is locally used. Done. > Should we declare prototypes for __weak functions? Anyway, we should remove > __weak from the prototypes. And done. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.