From: Yu Chen <yu.c.chen@intel.com>
To: joeyli <jlee@suse.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-kernel@vger.kernel.org,
Lenny Szubowicz <lszubowi@redhat.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Rui Zhang <rui.zhang@intel.com>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH][RFC v2] ACPI: acpi_pad: Do not launch acpi_pad threads on idle cpus
Date: Wed, 12 Dec 2018 09:56:57 +0800 [thread overview]
Message-ID: <20181212015656.GA25427@chenyu-desktop> (raw)
In-Reply-To: <20181211083754.GE28555@linux-l9pv.suse>
Hi,
On Tue, Dec 11, 2018 at 04:37:54PM +0800, joeyli wrote:
> Hi Yu Chen,
>
> Thanks for your response!
>
> On Tue, Dec 11, 2018 at 11:12:21AM +0800, Yu Chen wrote:
> > Hi Joey,
> > On Mon, Dec 10, 2018 at 02:31:53PM +0800, joeyli wrote:
> > > Hi Chen Yu and ACPI experts,
> > >
> > > On Sat, May 05, 2018 at 07:53:22PM +0800, Chen Yu wrote:
> > > > According to current implementation of acpi_pad driver,
> > > > it does not make sense to spawn any power saving threads
> > > > on the cpus which are already idle - it might bring
> > > > unnecessary overhead on these idle cpus and causes power
> > > > waste. So verify the condition that if the number of 'busy'
> > > > cpus exceeds the amount of the 'forced idle' cpus is met.
> > > > This is applicable due to round-robin attribute of the
> > > > power saving threads, otherwise ignore the setting/ACPI
> > > > notification.
> > > >
> > > > Suggested-by: Lenny Szubowicz <lszubowi@redhat.com>
> > > > Suggested-by: Len Brown <lenb@kernel.org>
> > > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> > > > Cc: Lenny Szubowicz <lszubowi@redhat.com>
> > > > Cc: Len Brown <lenb@kernel.org>
> > > > Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > > > Cc: Rui Zhang <rui.zhang@intel.com>
> > > > Cc: linux-acpi@vger.kernel.org
> > > > Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> > >
> > > Do you have any news for this patch? Why it did not merged by kernel
> > > maineline?
> > >
> > We are evaluating if this could be integrated into idle injection framework.
> > May I know if there's any requirement/background from SUSE on this?
> >
>
> I am also looking at your patch and idle injection framework. Currently I do not
> have good suggestion for your patches yet. But I will try to ready my knowledge when
> you send out new version.
>
Thanks. I mean, does SUSE get report from customers who encountered this issue?
BTW, may I know the status of the encryption hibernation please?(Usin the TPM?)
Best,
Yu(Ryan)
> Thanks a lot!
> Joey Lee
prev parent reply other threads:[~2018-12-12 1:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-05 11:53 [PATCH][RFC v2] ACPI: acpi_pad: Do not launch acpi_pad threads on idle cpus Chen Yu
2018-05-13 9:30 ` Rafael J. Wysocki
2018-05-14 15:45 ` Yu Chen
2018-05-14 20:42 ` Rafael J. Wysocki
2018-10-03 9:38 ` Rafael J. Wysocki
2018-12-10 6:31 ` joeyli
2018-12-11 3:12 ` Yu Chen
2018-12-11 8:37 ` joeyli
2018-12-12 1:56 ` Yu Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212015656.GA25427@chenyu-desktop \
--to=yu.c.chen@intel.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jlee@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lszubowi@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).