From: Will Deacon <will.deacon@arm.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Eric Auger <eric.auger@redhat.com>,
Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org, Hanjun Guo <hanjun.guo@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH] ACPI/IORT: Fix rc_dma_get_range()
Date: Fri, 11 Jan 2019 10:03:20 +0000 [thread overview]
Message-ID: <20190111100320.GA19110@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <20190110184151.27492-1-lorenzo.pieralisi@arm.com>
On Thu, Jan 10, 2019 at 06:41:51PM +0000, Lorenzo Pieralisi wrote:
> From: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
>
> When executed for a PCI_ROOT_COMPLEX type, iort_match_node_callback()
> expects the opaque pointer argument to be a PCI bus device. At the
> moment rc_dma_get_range() passes the PCI endpoint instead of the bus,
> and we've been lucky to have pci_domain_nr(ptr) return 0 instead of
> crashing. Pass the bus device to iort_scan_node().
>
> Fixes: 5ac65e8c8941 ("ACPI/IORT: Support address size limit for root complexes")
> Reported-by: Eric Auger <eric.auger@redhat.com>
> Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
> Acked-by: Robin Murphy <robin.murphy@arm.com>
> Cc: stable@vger.kernel.org
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Hanjun Guo <hanjun.guo@linaro.org>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> ---
> Will, Catalin,
>
> resending a reformatted version of this fix previously posted in [1],
> please merge it for one of the upcoming -rc.
Thanks, I'll push this out later today.
Will
prev parent reply other threads:[~2019-01-11 10:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 18:41 [RESEND PATCH] ACPI/IORT: Fix rc_dma_get_range() Lorenzo Pieralisi
2019-01-11 10:03 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111100320.GA19110@fuggles.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=catalin.marinas@arm.com \
--cc=eric.auger@redhat.com \
--cc=hanjun.guo@linaro.org \
--cc=jean-philippe.brucker@arm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robin.murphy@arm.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).