From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [RESEND PATCH] ACPI/IORT: Fix rc_dma_get_range() Date: Fri, 11 Jan 2019 10:03:20 +0000 Message-ID: <20190111100320.GA19110@fuggles.cambridge.arm.com> References: <20190110184151.27492-1-lorenzo.pieralisi@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190110184151.27492-1-lorenzo.pieralisi@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Lorenzo Pieralisi Cc: Eric Auger , Jean-Philippe Brucker , Catalin Marinas , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, Hanjun Guo , Sudeep Holla , Robin Murphy , linux-arm-kernel@lists.infradead.org List-Id: linux-acpi@vger.kernel.org On Thu, Jan 10, 2019 at 06:41:51PM +0000, Lorenzo Pieralisi wrote: > From: Jean-Philippe Brucker > > When executed for a PCI_ROOT_COMPLEX type, iort_match_node_callback() > expects the opaque pointer argument to be a PCI bus device. At the > moment rc_dma_get_range() passes the PCI endpoint instead of the bus, > and we've been lucky to have pci_domain_nr(ptr) return 0 instead of > crashing. Pass the bus device to iort_scan_node(). > > Fixes: 5ac65e8c8941 ("ACPI/IORT: Support address size limit for root complexes") > Reported-by: Eric Auger > Signed-off-by: Jean-Philippe Brucker > Signed-off-by: Lorenzo Pieralisi > Reviewed-by: Eric Auger > Acked-by: Robin Murphy > Cc: stable@vger.kernel.org > Cc: Will Deacon > Cc: Hanjun Guo > Cc: Sudeep Holla > Cc: Catalin Marinas > Cc: "Rafael J. Wysocki" > --- > Will, Catalin, > > resending a reformatted version of this fix previously posted in [1], > please merge it for one of the upcoming -rc. Thanks, I'll push this out later today. Will