Re: [PATCH 4/5] lib/vsprintf: Make use of fwnode API to obtain node names and separators

Petr Mladek
2019-03-27T12:53:56Z

On Fri 2019-03-22 17:29:29, Sakari Ailus wrote:
> Instead of implementing our own means of discovering parent nodes, node
> names or counting how many parents a node has, use the newly added
> functions in the fwnode API to obtain that information.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> lib/vsprintf.c | 37 +++++++++++++++----------------------
> 1 file changed, 15 insertions(+), 22 deletions(-)
>
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index 5f60b8d41277..91f2a3e4892e 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -37,6 +37,7 @@
> #include <net/addrconf.h>
> #include <linux/siphash.h>
> #include <linux/compiler.h>
> +#include <linux/property.h>
> #ifdef CONFIG_BLOCK
> #include <linux/blkdev.h>
> #endif
> @@ -1720,32 +1721,23 @@ char *flags_string(char *buf, char *end, void *flags_ptr, const char *fmt)
> return format_flags(buf, end, flags, names);
> }
>
> -static const char *device_node_name_for_depth(const struct device_node *np, int depth)
> -{
> - for ( ; np && depth; depth--)
> - np = np->parent;
> -
> - return kbasename(np->full_name);
> -}
> -
> static noinline_for_stack
> -char *device_node_gen_full_name(const struct device_node *np, char *buf, char *end)
> +char *fwnode_gen_full_name(struct fwnode_handle *fwnode, char *buf, char *end)

I first read this as fwnode_get_full_name(), see "get" vs. "gen".
I guess that it was because there is used also fwnode_get_name().

Please, rename it to fwnode_full_name_string() or so ;-)

Best Regards,
Petr