From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yue Haibing Subject: [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry Date: Thu, 4 Apr 2019 22:17:48 +0800 Message-ID: <20190404141748.27048-1-yuehaibing@huawei.com> References: <20190404104222.23900-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20190404104222.23900-1-yuehaibing@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: myungjoo.ham@samsung.com, cw00.choi@samsung.com, wens@csie.org, hdegoede@redhat.com, rjw@rjwysocki.net Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, YueHaibing List-Id: linux-acpi@vger.kernel.org From: YueHaibing As Hans de Goede pointed, using this driver without ACPI makes little sense, so add ACPI dependency to Kconfig entry to fix a build error while CONFIG_ACPI is not set. drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe': drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to incomplete type put_device(&adev->dev); Fixes: 0cf064db948a ("extcon: axp288: Convert to use acpi_dev_get_first_match_dev()") Reported-by: Hulk Robot Suggested-by: Hans de Goede Signed-off-by: YueHaibing --- v2: rework patch --- drivers/extcon/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig index 1ed4b45..de06faf 100644 --- a/drivers/extcon/Kconfig +++ b/drivers/extcon/Kconfig @@ -30,7 +30,7 @@ config EXTCON_ARIZONA config EXTCON_AXP288 tristate "X-Power AXP288 EXTCON support" - depends on MFD_AXP20X && USB_SUPPORT && X86 + depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI select USB_ROLE_SWITCH help Say Y here to enable support for USB peripheral detection -- 2.7.4