From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2] gpio: merrifield: Fix build err without CONFIG_ACPI Date: Fri, 5 Apr 2019 17:50:09 +0300 Message-ID: <20190405145009.GD9224@smile.fi.intel.com> References: <20190404103925.25652-1-yuehaibing@huawei.com> <20190405142112.26592-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190405142112.26592-1-yuehaibing@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: Yue Haibing Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On Fri, Apr 05, 2019 at 10:21:12PM +0800, Yue Haibing wrote: > From: YueHaibing > > When building CONFIG_ACPI is not set > gcc warn this: > > drivers/gpio/gpio-merrifield.c: In function mrfld_gpio_get_pinctrl_dev_name: > drivers/gpio/gpio-merrifield.c:388:19: error: dereferencing pointer to incomplete type struct acpi_device > put_device(&adev->dev); > ^ > Reported-by: Hulk Robot > Suggested-by: Andy Shevchenko > Fixes:d00d2109c367 ("gpio: merrifield: Convert to use acpi_dev_get_first_match_dev()") > Signed-off-by: YueHaibing Thank you for an update, I have a comment below, but before sending v3, let Rafael to have a chance to look at it. > #ifdef CONFIG_ACPI > extern int acpi_platform_notify(struct device *dev, enum kobject_action action); > + > +static inline void put_acpi_device(struct acpi_device *adev) > +{ > + put_device(&adev->dev); > +} This should probably go to acpi_bus.h under acpi_dev_get_first_match_dev(). And talking to Mika we agreed that naming would be better as acpi_dev_put(). -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B62F8C4360F for ; Fri, 5 Apr 2019 14:50:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9127321852 for ; Fri, 5 Apr 2019 14:50:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726714AbfDEOuR (ORCPT ); Fri, 5 Apr 2019 10:50:17 -0400 Received: from mga12.intel.com ([192.55.52.136]:60091 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726594AbfDEOuR (ORCPT ); Fri, 5 Apr 2019 10:50:17 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2019 07:50:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,313,1549958400"; d="scan'208";a="131759100" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga008.jf.intel.com with ESMTP; 05 Apr 2019 07:50:10 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hCQAT-0001v1-DC; Fri, 05 Apr 2019 17:50:09 +0300 Date: Fri, 5 Apr 2019 17:50:09 +0300 From: Andy Shevchenko To: Yue Haibing Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2] gpio: merrifield: Fix build err without CONFIG_ACPI Message-ID: <20190405145009.GD9224@smile.fi.intel.com> References: <20190404103925.25652-1-yuehaibing@huawei.com> <20190405142112.26592-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190405142112.26592-1-yuehaibing@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Message-ID: <20190405145009.lmjb2tY8Sk5jNpgngM-jYbOGqf-w42JkM_T-QMJVk1Y@z> On Fri, Apr 05, 2019 at 10:21:12PM +0800, Yue Haibing wrote: > From: YueHaibing > > When building CONFIG_ACPI is not set > gcc warn this: > > drivers/gpio/gpio-merrifield.c: In function mrfld_gpio_get_pinctrl_dev_name: > drivers/gpio/gpio-merrifield.c:388:19: error: dereferencing pointer to incomplete type struct acpi_device > put_device(&adev->dev); > ^ > Reported-by: Hulk Robot > Suggested-by: Andy Shevchenko > Fixes:d00d2109c367 ("gpio: merrifield: Convert to use acpi_dev_get_first_match_dev()") > Signed-off-by: YueHaibing Thank you for an update, I have a comment below, but before sending v3, let Rafael to have a chance to look at it. > #ifdef CONFIG_ACPI > extern int acpi_platform_notify(struct device *dev, enum kobject_action action); > + > +static inline void put_acpi_device(struct acpi_device *adev) > +{ > + put_device(&adev->dev); > +} This should probably go to acpi_bus.h under acpi_dev_get_first_match_dev(). And talking to Mika we agreed that naming would be better as acpi_dev_put(). -- With Best Regards, Andy Shevchenko