From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heikki Krogerus Subject: Re: [PATCH 10/11] platform/x86: intel_cht_int33fe: Link with external dependencies using fwnodes Date: Tue, 9 Apr 2019 15:38:20 +0300 Message-ID: <20190409123820.GA20058@kuha.fi.intel.com> References: <20190403164537.24643-1-heikki.krogerus@linux.intel.com> <20190403164537.24643-11-heikki.krogerus@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: "Rafael J. Wysocki" , Greg Kroah-Hartman , Hans de Goede , Darren Hart , Andy Shevchenko , ACPI Devel Maling List , Linux Kernel Mailing List , Platform Driver List-Id: linux-acpi@vger.kernel.org On Mon, Apr 08, 2019 at 07:42:52PM +0300, Andy Shevchenko wrote: > On Wed, Apr 3, 2019 at 7:46 PM Heikki Krogerus > wrote: > > > > Supplying also external devices - the DisplayPort connector > > and the USB role switch - software fwnodes. After this the > > driver has access to all the components tied to the USB > > Type-C connector and can start creating software node > > references to actually associate them with the USB Type-C > > connector device. > > > +static int role_switch_match(struct device *dev, void *name) > > +{ > > + return !strcmp(dev_name(dev), name); > > +} > > + > > +static int cht_int33fe_setup_mux(struct cht_int33fe_data *data) > > +{ > > > + /* First let's find xHCI PCI device */ > > + pdev = pci_get_class(PCI_CLASS_SERIAL_USB_XHCI, NULL); > > + if (!pdev || (pdev->vendor != PCI_VENDOR_ID_INTEL)) > > + return -ENODEV; > > + > > > + /* Then the child platform device */ > > + p = device_find_child(&pdev->dev, "intel_xhci_usb_sw", > > + role_switch_match); > > We have already similar code in kernel > (drivers/nvdimm/claim.c::namespace_match), perhaps > you at least can (locally) introduce > > static int match_name(...) // or re-use from drivers/base/bus.c > { > ... > } OK. > static device_find_child_by_name(...) > { > ... > } > > which we may move to the driver core now or later on. > > > + pci_dev_put(pdev); > > + if (!p) > > + return -EPROBE_DEFER; > > + > > > + /* Finally the mux device */ > > + dev = device_find_child(p, "intel_xhci_usb_sw-role-switch", > > + role_switch_match); > > Ditto. > > > + put_device(p); > > + if (!dev) > > + return -EPROBE_DEFER; > > > + return 0; > > > +} > > > +static int cht_int33fe_setup_dp(struct cht_int33fe_data *data) > > +{ > > + struct fwnode_handle *fwnode = data->node[INT33FE_NODE_DISPLAYPORT]; > > + struct pci_dev *pdev; > > + > > + /* First let's find the GPU PCI device */ > > + pdev = pci_get_class(PCI_CLASS_DISPLAY_VGA << 8, NULL); > > + if (!pdev || (pdev->vendor != PCI_VENDOR_ID_INTEL)) > > + return -ENODEV; > > + > > + /* Then the DP child device node */ > > + data->dp = device_get_named_child_node(&pdev->dev, "DD02"); > > + pci_dev_put(pdev); > > + if (!data->dp) > > + return -ENODEV; > > + > > > + fwnode->secondary = ERR_PTR(-ENODEV); > > + data->dp->secondary = fwnode; > > Can't generic helper be in charge of doing this, i.e. chaining fwnodes? > > /// > void fwnode_chain(parent, new) > { > ... > } > /// We probable should just export set_secondary_fwnode(). I'll add a patch for that. thanks Andy, -- heikki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2BC6C10F0E for ; Tue, 9 Apr 2019 12:38:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98FD22084F for ; Tue, 9 Apr 2019 12:38:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726112AbfDIMi0 (ORCPT ); Tue, 9 Apr 2019 08:38:26 -0400 Received: from mga09.intel.com ([134.134.136.24]:36128 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726001AbfDIMi0 (ORCPT ); Tue, 9 Apr 2019 08:38:26 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 05:38:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,329,1549958400"; d="scan'208";a="162716165" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 09 Apr 2019 05:38:21 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 09 Apr 2019 15:38:20 +0300 Date: Tue, 9 Apr 2019 15:38:20 +0300 From: Heikki Krogerus To: Andy Shevchenko Cc: "Rafael J. Wysocki" , Greg Kroah-Hartman , Hans de Goede , Darren Hart , Andy Shevchenko , ACPI Devel Maling List , Linux Kernel Mailing List , Platform Driver Subject: Re: [PATCH 10/11] platform/x86: intel_cht_int33fe: Link with external dependencies using fwnodes Message-ID: <20190409123820.GA20058@kuha.fi.intel.com> References: <20190403164537.24643-1-heikki.krogerus@linux.intel.com> <20190403164537.24643-11-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Message-ID: <20190409123820.AnPCcrn5m43F6afYsA8-sVGOHeMOdUmjx1HjOMSKyrk@z> On Mon, Apr 08, 2019 at 07:42:52PM +0300, Andy Shevchenko wrote: > On Wed, Apr 3, 2019 at 7:46 PM Heikki Krogerus > wrote: > > > > Supplying also external devices - the DisplayPort connector > > and the USB role switch - software fwnodes. After this the > > driver has access to all the components tied to the USB > > Type-C connector and can start creating software node > > references to actually associate them with the USB Type-C > > connector device. > > > +static int role_switch_match(struct device *dev, void *name) > > +{ > > + return !strcmp(dev_name(dev), name); > > +} > > + > > +static int cht_int33fe_setup_mux(struct cht_int33fe_data *data) > > +{ > > > + /* First let's find xHCI PCI device */ > > + pdev = pci_get_class(PCI_CLASS_SERIAL_USB_XHCI, NULL); > > + if (!pdev || (pdev->vendor != PCI_VENDOR_ID_INTEL)) > > + return -ENODEV; > > + > > > + /* Then the child platform device */ > > + p = device_find_child(&pdev->dev, "intel_xhci_usb_sw", > > + role_switch_match); > > We have already similar code in kernel > (drivers/nvdimm/claim.c::namespace_match), perhaps > you at least can (locally) introduce > > static int match_name(...) // or re-use from drivers/base/bus.c > { > ... > } OK. > static device_find_child_by_name(...) > { > ... > } > > which we may move to the driver core now or later on. > > > + pci_dev_put(pdev); > > + if (!p) > > + return -EPROBE_DEFER; > > + > > > + /* Finally the mux device */ > > + dev = device_find_child(p, "intel_xhci_usb_sw-role-switch", > > + role_switch_match); > > Ditto. > > > + put_device(p); > > + if (!dev) > > + return -EPROBE_DEFER; > > > + return 0; > > > +} > > > +static int cht_int33fe_setup_dp(struct cht_int33fe_data *data) > > +{ > > + struct fwnode_handle *fwnode = data->node[INT33FE_NODE_DISPLAYPORT]; > > + struct pci_dev *pdev; > > + > > + /* First let's find the GPU PCI device */ > > + pdev = pci_get_class(PCI_CLASS_DISPLAY_VGA << 8, NULL); > > + if (!pdev || (pdev->vendor != PCI_VENDOR_ID_INTEL)) > > + return -ENODEV; > > + > > + /* Then the DP child device node */ > > + data->dp = device_get_named_child_node(&pdev->dev, "DD02"); > > + pci_dev_put(pdev); > > + if (!data->dp) > > + return -ENODEV; > > + > > > + fwnode->secondary = ERR_PTR(-ENODEV); > > + data->dp->secondary = fwnode; > > Can't generic helper be in charge of doing this, i.e. chaining fwnodes? > > /// > void fwnode_chain(parent, new) > { > ... > } > /// We probable should just export set_secondary_fwnode(). I'll add a patch for that. thanks Andy, -- heikki