From: Pankaj Gupta <pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: jack-AlSwsSmVLrQ@public.gmane.org,
mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org,
lcapitulino-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org,
zwisler-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
david-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
nilal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
kilobyte-b9QjgO8OEXPVItvQsEIGlw@public.gmane.org,
riel-ebMLmSuQjDVBDgjK7y7TUQ@public.gmane.org,
yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
stefanha-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
kwolf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
tytso-3s7WtUTddSA@public.gmane.org,
xiaoguangrong.eric-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
cohuck-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org,
imammedo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: [PATCH v5 6/6] xfs: disable map_sync for async flush
Date: Wed, 10 Apr 2019 09:38:26 +0530 [thread overview]
Message-ID: <20190410040826.24371-7-pagupta@redhat.com> (raw)
In-Reply-To: <20190410040826.24371-1-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Dont support 'MAP_SYNC' with non-DAX files and DAX files
with asynchronous dax_device. Virtio pmem provides
asynchronous host page cache flush mechanism. We don't
support 'MAP_SYNC' with virtio pmem and xfs.
Signed-off-by: Pankaj Gupta <pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
fs/xfs/xfs_file.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index 1f2e2845eb76..0e59be018511 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -1196,11 +1196,13 @@ xfs_file_mmap(
struct file *filp,
struct vm_area_struct *vma)
{
- /*
- * We don't support synchronous mappings for non-DAX files. At least
- * until someone comes with a sensible use case.
+ struct dax_device *dax_dev = xfs_find_daxdev_for_inode
+ (file_inode(filp));
+
+ /* We don't support synchronous mappings for non-DAX files and
+ * for DAX files if underneath dax_device is not synchronous.
*/
- if (!IS_DAX(file_inode(filp)) && (vma->vm_flags & VM_SYNC))
+ if (!daxdev_mapping_supported(vma, dax_dev))
return -EOPNOTSUPP;
file_accessed(filp);
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Pankaj Gupta <pagupta@redhat.com>
To: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org,
qemu-devel@nongnu.org, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org
Cc: dan.j.williams@intel.com, zwisler@kernel.org,
vishal.l.verma@intel.com, dave.jiang@intel.com, mst@redhat.com,
jasowang@redhat.com, willy@infradead.org, rjw@rjwysocki.net,
hch@infradead.org, lenb@kernel.org, jack@suse.cz, tytso@mit.edu,
adilger.kernel@dilger.ca, darrick.wong@oracle.com,
lcapitulino@redhat.com, kwolf@redhat.com, imammedo@redhat.com,
jmoyer@redhat.com, nilal@redhat.com, riel@surriel.com,
stefanha@redhat.com, aarcange@redhat.com, david@redhat.com,
david@fromorbit.com, cohuck@redhat.com,
xiaoguangrong.eric@gmail.com, pbonzini@redhat.com,
kilobyte@angband.pl, yuval.shaia@oracle.com, pagupta@redhat.com
Subject: [PATCH v5 6/6] xfs: disable map_sync for async flush
Date: Wed, 10 Apr 2019 09:38:26 +0530 [thread overview]
Message-ID: <20190410040826.24371-7-pagupta@redhat.com> (raw)
Message-ID: <20190410040826._oEAZ4iZn8IbHMx1AUlP6U67q5kV0IaKHLnGnjxq81E@z> (raw)
In-Reply-To: <20190410040826.24371-1-pagupta@redhat.com>
Dont support 'MAP_SYNC' with non-DAX files and DAX files
with asynchronous dax_device. Virtio pmem provides
asynchronous host page cache flush mechanism. We don't
support 'MAP_SYNC' with virtio pmem and xfs.
Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
---
fs/xfs/xfs_file.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index 1f2e2845eb76..0e59be018511 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -1196,11 +1196,13 @@ xfs_file_mmap(
struct file *filp,
struct vm_area_struct *vma)
{
- /*
- * We don't support synchronous mappings for non-DAX files. At least
- * until someone comes with a sensible use case.
+ struct dax_device *dax_dev = xfs_find_daxdev_for_inode
+ (file_inode(filp));
+
+ /* We don't support synchronous mappings for non-DAX files and
+ * for DAX files if underneath dax_device is not synchronous.
*/
- if (!IS_DAX(file_inode(filp)) && (vma->vm_flags & VM_SYNC))
+ if (!daxdev_mapping_supported(vma, dax_dev))
return -EOPNOTSUPP;
file_accessed(filp);
--
2.20.1
next prev parent reply other threads:[~2019-04-10 4:08 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 4:08 [PATCH v5 0/6] virtio pmem driver Pankaj Gupta
2019-04-10 4:08 ` Pankaj Gupta
2019-04-10 4:08 ` [PATCH v5 3/6] libnvdimm: add dax_dev sync flag Pankaj Gupta
2019-04-10 4:08 ` Pankaj Gupta
2019-04-10 8:28 ` Jan Kara
2019-04-10 8:28 ` Jan Kara
2019-04-10 8:38 ` Pankaj Gupta
2019-04-10 8:38 ` Pankaj Gupta
2019-04-11 14:56 ` Dan Williams
2019-04-11 14:56 ` Dan Williams
2019-04-11 15:39 ` Pankaj Gupta
2019-04-11 15:39 ` Pankaj Gupta
2019-04-10 4:08 ` [PATCH v5 4/6] dax: check synchronous mapping is supported Pankaj Gupta
2019-04-10 4:08 ` Pankaj Gupta
[not found] ` <20190410040826.24371-5-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-04-10 8:25 ` Jan Kara
2019-04-10 8:25 ` Jan Kara
2019-04-10 8:31 ` Pankaj Gupta
2019-04-10 8:31 ` Pankaj Gupta
[not found] ` <20190410040826.24371-1-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-04-10 4:08 ` [PATCH v5 1/6] libnvdimm: nd_region flush callback support Pankaj Gupta
2019-04-10 4:08 ` Pankaj Gupta
[not found] ` <20190410040826.24371-2-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-04-11 14:51 ` Dan Williams
2019-04-11 14:51 ` Dan Williams
2019-04-11 15:57 ` [Qemu-devel] " Pankaj Gupta
2019-04-11 15:57 ` Pankaj Gupta
[not found] ` <1463291806.21158433.1554998258746.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-04-11 16:09 ` Dan Williams
2019-04-11 16:09 ` Dan Williams
2019-04-11 16:23 ` Pankaj Gupta
2019-04-11 16:23 ` Pankaj Gupta
2019-04-12 8:32 ` Jan Kara
2019-04-12 8:32 ` Jan Kara
2019-04-12 13:12 ` Jeff Moyer
2019-04-12 13:12 ` Jeff Moyer
2019-04-18 6:27 ` [Qemu-devel] " Pankaj Gupta
2019-04-18 6:27 ` Pankaj Gupta
2019-04-18 16:05 ` Dan Williams
2019-04-18 16:05 ` Dan Williams
2019-04-18 16:10 ` Jeff Moyer
2019-04-18 16:10 ` Jeff Moyer
2019-04-18 16:18 ` Christoph Hellwig
2019-04-18 16:18 ` Christoph Hellwig
[not found] ` <20190418161833.GA22970-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2019-04-18 18:14 ` Dan Williams
2019-04-18 18:14 ` Dan Williams
2019-04-22 15:51 ` Jeff Moyer
2019-04-22 15:51 ` Jeff Moyer
2019-04-22 19:44 ` Dan Williams
2019-04-22 19:44 ` Dan Williams
2019-04-22 21:03 ` Jeff Moyer
2019-04-22 21:03 ` Jeff Moyer
[not found] ` <x49ef5t7nwp.fsf-RRHT56Q3PSP4kTEheFKJxxDDeQx5vsVwAInAS/Ez/D0@public.gmane.org>
2019-04-23 4:07 ` Pankaj Gupta
2019-04-23 4:07 ` Pankaj Gupta
2019-04-10 4:08 ` [PATCH v5 2/5] virtio-pmem: Add virtio pmem driver Pankaj Gupta
2019-04-10 4:08 ` Pankaj Gupta
2019-04-10 12:24 ` Cornelia Huck
2019-04-10 12:24 ` Cornelia Huck
[not found] ` <20190410142426.5bf0d9a4.cohuck-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-04-10 14:38 ` Yuval Shaia
2019-04-10 14:38 ` Yuval Shaia
2019-04-10 15:44 ` Pankaj Gupta
2019-04-10 15:44 ` Pankaj Gupta
2019-04-10 15:38 ` Pankaj Gupta
2019-04-10 15:38 ` Pankaj Gupta
[not found] ` <20190410040826.24371-3-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-04-10 13:12 ` Michael S. Tsirkin
2019-04-10 13:12 ` Michael S. Tsirkin
[not found] ` <20190410091216-mutt-send-email-mst-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2019-04-10 14:03 ` [Qemu-devel] " Pankaj Gupta
2019-04-10 14:03 ` Pankaj Gupta
2019-04-10 14:31 ` Cornelia Huck
2019-04-10 14:31 ` Cornelia Huck
2019-04-10 16:46 ` Michael S. Tsirkin
2019-04-10 16:46 ` Michael S. Tsirkin
2019-04-10 16:52 ` Cornelia Huck
2019-04-10 16:52 ` Cornelia Huck
2019-04-10 14:41 ` Yuval Shaia
2019-04-10 14:41 ` Yuval Shaia
2019-04-10 4:08 ` [PATCH v5 5/6] ext4: disable map_sync for async flush Pankaj Gupta
2019-04-10 4:08 ` Pankaj Gupta
2019-04-10 4:08 ` Pankaj Gupta [this message]
2019-04-10 4:08 ` [PATCH v5 6/6] xfs: " Pankaj Gupta
2019-04-10 8:08 ` [PATCH v5 0/6] virtio pmem driver Arkadiusz Miśkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410040826.24371-7-pagupta@redhat.com \
--to=pagupta-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org \
--cc=cohuck-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org \
--cc=david-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=imammedo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=kilobyte-b9QjgO8OEXPVItvQsEIGlw@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kwolf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=lcapitulino-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=nilal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
--cc=riel-ebMLmSuQjDVBDgjK7y7TUQ@public.gmane.org \
--cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
--cc=stefanha-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tytso-3s7WtUTddSA@public.gmane.org \
--cc=virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=xiaoguangrong.eric-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=zwisler-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox