Re: [PATCH v5 3/6] libnvdimm: add dax_dev sync flag

Pankaj Gupta
2019-04-10T08:38:33Z

>
> On Wed 10-04-19 09:38:23, Pankaj Gupta wrote:
> > @@ -64,6 +65,10 @@ static inline bool dax_write_cache_enabled(struct
> > dax_device *dax_dev)
> > {
> > return false;
> > }
> > +static inline bool dax_synchronous(struct dax_device *dax_dev)
> > +{
> > + return true;
> > +}
>
> Is there a need to define dax_synchronous() for !CONFIG_DAX? Because that
> property of dax device is pretty much undefined and I don't see anything
> needing to call it for !CONFIG_DAX...

You are right. Will remove this.

Thanks for the review.

Best regards,
Pankaj

>
> Honza
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
>