From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alison Schofield Subject: Re: [PATCH] acpi/hmat: Update acpi_hmat_type enum with ACPI_HMAT_TYPE_PROXIMITY Date: Fri, 19 Apr 2019 09:54:35 -0700 Message-ID: <20190419165435.GA2284@alison-desk.jf.intel.com> References: <20190417181310.27613-1-alison.schofield@intel.com> <20190418145640.GA7659@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: Keith Busch , "Rafael J. Wysocki" , Robert Moore , "Schmauss, Erik" , ACPI Devel Maling List , Linux Kernel Mailing List List-Id: linux-acpi@vger.kernel.org On Thu, Apr 18, 2019 at 05:07:12PM +0200, Rafael J. Wysocki wrote: > On Thu, Apr 18, 2019 at 5:02 PM Keith Busch wrote: > > > > On Wed, Apr 17, 2019 at 11:13:10AM -0700, Alison Schofield wrote: > > > ACPI 6.3 changed the subtable "Memory Subsystem Address Range Structure" > > > to "Memory Proximity Domain Attributes Structure". > > > > > > Updating and renaming of the structure was included in commit: > > > ACPICA: ACPI 6.3: HMAT updates (9a8d961f1ef835b0d338fbe13da03cb424e87ae5) > > > > I was not really happy with that HMAT update. Platforms implementing > > 6.2's HMAT continue to exist even if 6.3 isn't backward compatible. We > > just lost the original subtable definition. > > Well, that's true, sadly, but the question is what to do in the kernel. > > Definitely, the 6.3 format needs to be supported, but if the 6.2 ships > anywhere in practice, that will need to be supported too. So, what's the usual practice when ACPI tables are updated? Do we define separate 6.2 and 6.3 versions of this subtable and let the kernel figure out which one its looking at? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 077BBC282DA for ; Fri, 19 Apr 2019 18:26:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1CC2222C5 for ; Fri, 19 Apr 2019 18:26:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726150AbfDSS0w (ORCPT ); Fri, 19 Apr 2019 14:26:52 -0400 Received: from mga04.intel.com ([192.55.52.120]:9990 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727518AbfDSS0m (ORCPT ); Fri, 19 Apr 2019 14:26:42 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2019 09:51:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,370,1549958400"; d="scan'208";a="137202297" Received: from alison-desk.jf.intel.com ([10.54.74.53]) by orsmga006.jf.intel.com with ESMTP; 19 Apr 2019 09:51:39 -0700 Date: Fri, 19 Apr 2019 09:54:35 -0700 From: Alison Schofield To: "Rafael J. Wysocki" Cc: Keith Busch , "Rafael J. Wysocki" , Robert Moore , "Schmauss, Erik" , ACPI Devel Maling List , Linux Kernel Mailing List Subject: Re: [PATCH] acpi/hmat: Update acpi_hmat_type enum with ACPI_HMAT_TYPE_PROXIMITY Message-ID: <20190419165435.GA2284@alison-desk.jf.intel.com> References: <20190417181310.27613-1-alison.schofield@intel.com> <20190418145640.GA7659@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Message-ID: <20190419165435.IJLNWdArYuRYw1m1EQqG34JOZ6SFxgOIf89iuVbwLL4@z> On Thu, Apr 18, 2019 at 05:07:12PM +0200, Rafael J. Wysocki wrote: > On Thu, Apr 18, 2019 at 5:02 PM Keith Busch wrote: > > > > On Wed, Apr 17, 2019 at 11:13:10AM -0700, Alison Schofield wrote: > > > ACPI 6.3 changed the subtable "Memory Subsystem Address Range Structure" > > > to "Memory Proximity Domain Attributes Structure". > > > > > > Updating and renaming of the structure was included in commit: > > > ACPICA: ACPI 6.3: HMAT updates (9a8d961f1ef835b0d338fbe13da03cb424e87ae5) > > > > I was not really happy with that HMAT update. Platforms implementing > > 6.2's HMAT continue to exist even if 6.3 isn't backward compatible. We > > just lost the original subtable definition. > > Well, that's true, sadly, but the question is what to do in the kernel. > > Definitely, the 6.3 format needs to be supported, but if the 6.2 ships > anywhere in practice, that will need to be supported too. So, what's the usual practice when ACPI tables are updated? Do we define separate 6.2 and 6.3 versions of this subtable and let the kernel figure out which one its looking at?