From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH v4 00/63] Include linux ACPI/PCI/X86 docs into Sphinx TOC tree Date: Wed, 24 Apr 2019 14:48:30 -0300 Message-ID: <20190424144830.3fe92640@coco.lan> References: <20190423162932.21428-1-changbin.du@gmail.com> <20190423173644.GA14616@google.com> <20190424154617.kowr5aamjkeceltr@mail.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190424154617.kowr5aamjkeceltr@mail.google.com> Sender: linux-kernel-owner@vger.kernel.org To: Changbin Du Cc: Bjorn Helgaas , "Rafael J. Wysocki" , Jonathan Corbet , "Rafael J. Wysocki" , Linux PCI , "open list:DOCUMENTATION" , Linux Kernel Mailing List , Thomas Gleixner , Ingo Molnar , the arch/x86 maintainers , Fenghua Yu , linuxppc-dev , ACPI Devel Maling List , linux-gpio@vger.kernel.org List-Id: linux-acpi@vger.kernel.org Em Wed, 24 Apr 2019 23:46:18 +0800 Changbin Du escreveu: > On Tue, Apr 23, 2019 at 12:36:44PM -0500, Bjorn Helgaas wrote: > > On Tue, Apr 23, 2019 at 06:39:47PM +0200, Rafael J. Wysocki wrote: > > > On Tue, Apr 23, 2019 at 6:30 PM Changbin Du wrote: > > > > Hi Corbet and All, > > > > The kernel now uses Sphinx to generate intelligent and beautiful > > > > documentation from reStructuredText files. I converted all of the Linux > > > > ACPI/PCI/X86 docs to reST format in this serias. > > > > > > > > In this version I combined ACPI and PCI docs, and added new x86 docs > > > > conversion. > > > > > > I'm not sure if combining all three into one big patch series has been > > > a good idea, honestly. > > > > Yeah, if you post this again, I would find it easier to deal with if > > linux-pci only got the PCI-related things. 63 patches is a little too > > much for one series. > > > sure, so I will resend them respectively. I reviewed up to patch 39. There are too many files on x86 that seems to be mangled by some tab->whitespace conversion, with caused very big diffs and lots of broken ascii artwork. Please ensure that the diffs will contain the minimal amount of stuff that would be required for them to be properly formatted as ReST files there. Ah, perhaps next time you could format the patches with a lower merge similarity logic (using, for example, the parameter -M10). Regards, Mauro > > > Bjorn > Thanks, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EA15C10F11 for ; Wed, 24 Apr 2019 17:48:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E0D2F21773 for ; Wed, 24 Apr 2019 17:48:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556128124; bh=ZoHvGVSFVuNaTJA1IG6BYbipl8kk0rjoziuacBSlSi8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=rAkBu6N+p7sTL7WnaUAwQNFa/A/KV77Q7CDMloOsew9vtSHrktRDJGYcfKqP5vhqz tXkBz9NvQYlCNa3g2HSkFtL3sg4JseNhdXnPaxoBRRKYCft3F8KUelQb7OJizOLTx9 rX7nkvHvYGuZHpDUkCC4dtBJUegdKhlh6bP3haXo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391334AbfDXRsm (ORCPT ); Wed, 24 Apr 2019 13:48:42 -0400 Received: from casper.infradead.org ([85.118.1.10]:45360 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390660AbfDXRsl (ORCPT ); Wed, 24 Apr 2019 13:48:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=C+jH5MB5a2swmKkEdfeQTYpVl5aRBU1fzkhBf76AiTM=; b=SPdkI3i9xCTD0C8C2HRlxJ8DA3 JcezKeaj8JAP8fVRdaJDeDKK6RloQJbb2BuU60+tFeE+UcWTi3KN495/SKkSEmK6o7cBGYmc92V5x PS8zILU/LaafDfuxLVLUPv5FSILDR6mIvL43565SCPSLnLL6LLWHSl8PKlnVoJOl0Vom5bsBe3yYZ pwoy2EiUJKa+UumDtWbeWLGKyY8rT2SXc50+0g54tUYaCfaJgVjPDrhqj9/VsBCLoM+nNuVjx94pV 50qmTl+wEPN4xduztx1gI1Obywoh/vh1cgjUSRM857lTM4O0Rq2E9pFGBojPJnHI8CuJ1Vg1iU2c7 y9GU4zyQ==; Received: from 177.17.136.231.dynamic.adsl.gvt.net.br ([177.17.136.231] helo=coco.lan) by casper.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJM0a-0000B8-TV; Wed, 24 Apr 2019 17:48:37 +0000 Date: Wed, 24 Apr 2019 14:48:30 -0300 From: Mauro Carvalho Chehab To: Changbin Du Cc: Bjorn Helgaas , "Rafael J. Wysocki" , Jonathan Corbet , "Rafael J. Wysocki" , Linux PCI , "open list:DOCUMENTATION" , Linux Kernel Mailing List , Thomas Gleixner , Ingo Molnar , the arch/x86 maintainers , Fenghua Yu , linuxppc-dev , ACPI Devel Maling List , linux-gpio@vger.kernel.org Subject: Re: [PATCH v4 00/63] Include linux ACPI/PCI/X86 docs into Sphinx TOC tree Message-ID: <20190424144830.3fe92640@coco.lan> In-Reply-To: <20190424154617.kowr5aamjkeceltr@mail.google.com> References: <20190423162932.21428-1-changbin.du@gmail.com> <20190423173644.GA14616@google.com> <20190424154617.kowr5aamjkeceltr@mail.google.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Message-ID: <20190424174830.91Vu4wKfws0J33SGfcME9Ony42RUOTQfpI5PtbwHPVU@z> Em Wed, 24 Apr 2019 23:46:18 +0800 Changbin Du escreveu: > On Tue, Apr 23, 2019 at 12:36:44PM -0500, Bjorn Helgaas wrote: > > On Tue, Apr 23, 2019 at 06:39:47PM +0200, Rafael J. Wysocki wrote: > > > On Tue, Apr 23, 2019 at 6:30 PM Changbin Du wrote: > > > > Hi Corbet and All, > > > > The kernel now uses Sphinx to generate intelligent and beautiful > > > > documentation from reStructuredText files. I converted all of the Linux > > > > ACPI/PCI/X86 docs to reST format in this serias. > > > > > > > > In this version I combined ACPI and PCI docs, and added new x86 docs > > > > conversion. > > > > > > I'm not sure if combining all three into one big patch series has been > > > a good idea, honestly. > > > > Yeah, if you post this again, I would find it easier to deal with if > > linux-pci only got the PCI-related things. 63 patches is a little too > > much for one series. > > > sure, so I will resend them respectively. I reviewed up to patch 39. There are too many files on x86 that seems to be mangled by some tab->whitespace conversion, with caused very big diffs and lots of broken ascii artwork. Please ensure that the diffs will contain the minimal amount of stuff that would be required for them to be properly formatted as ReST files there. Ah, perhaps next time you could format the patches with a lower merge similarity logic (using, for example, the parameter -M10). Regards, Mauro > > > Bjorn > Thanks, Mauro