public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Yue Haibing <yuehaibing@huawei.com>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v3] gpio: merrifield: Fix build err without CONFIG_ACPI
Date: Fri, 26 Apr 2019 15:23:17 +0300	[thread overview]
Message-ID: <20190426122317.GP9224@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkda_xw2rdzSLcreHnfdwsmUMTR=+BRHJWjrE31COaZhtZw@mail.gmail.com>

On Tue, Apr 23, 2019 at 11:17:32AM +0200, Linus Walleij wrote:
> On Fri, Apr 12, 2019 at 5:20 PM Yue Haibing <yuehaibing@huawei.com> wrote:
> 
> > From: YueHaibing <yuehaibing@huawei.com>
> >
> > When building CONFIG_ACPI is not set
> > gcc warn this:
> >
> > drivers/gpio/gpio-merrifield.c: In function mrfld_gpio_get_pinctrl_dev_name:
> > drivers/gpio/gpio-merrifield.c:388:19: error: dereferencing pointer to incomplete type struct acpi_device
> >    put_device(&adev->dev);
> >                    ^~
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Fixes:d00d2109c367 ("gpio: merrifield: Convert to use acpi_dev_get_first_match_dev()")
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> 
> This doesn't apply cleanly to any GPIO branch (devel or fixes)
> so I assume it is supposed to be applied to the ACPI tree.
> Acked-by: Linus Walleij <linus.walleij@linaro.org>

Thanks!
Rafael, can this be applied to your tree?

-- 
With Best Regards,
Andy Shevchenko

  parent reply	other threads:[~2019-04-26 12:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190404103925.25652-1-yuehaibing@huawei.com>
2019-04-04 14:04 ` [PATCH] gpio: merrifield: Fix build err without CONFIG_ACPI YueHaibing
2019-04-05 10:07   ` Andy Shevchenko
2019-04-05 10:07     ` Andy Shevchenko
2019-04-05 12:11     ` YueHaibing
2019-04-05 12:11       ` YueHaibing
2019-04-05 14:21 ` [PATCH v2] " Yue Haibing
2019-04-05 14:21   ` Yue Haibing
2019-04-05 14:50   ` Andy Shevchenko
2019-04-05 14:50     ` Andy Shevchenko
2019-04-11 23:09     ` Rafael J. Wysocki
2019-04-11 23:09       ` Rafael J. Wysocki
2019-04-12 13:13       ` Andy Shevchenko
2019-04-12 13:13         ` Andy Shevchenko
2019-04-12 13:26         ` YueHaibing
2019-04-12 13:26           ` YueHaibing
2019-04-12 15:19   ` [PATCH v3] " Yue Haibing
2019-04-12 15:19     ` Yue Haibing
2019-04-12 17:56     ` Andy Shevchenko
2019-04-12 17:56       ` Andy Shevchenko
2019-04-23  9:17     ` Linus Walleij
2019-04-23  9:17       ` Linus Walleij
2019-04-26 12:23       ` Andy Shevchenko [this message]
2019-04-26 12:23         ` Andy Shevchenko
2019-04-29  8:40         ` Rafael J. Wysocki
2019-04-29  8:40           ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190426122317.GP9224@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox