From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v3] gpio: merrifield: Fix build err without CONFIG_ACPI Date: Fri, 26 Apr 2019 15:23:17 +0300 Message-ID: <20190426122317.GP9224@smile.fi.intel.com> References: <20190405142112.26592-1-yuehaibing@huawei.com> <20190412151911.12084-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Yue Haibing , Bartosz Golaszewski , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , ACPI Devel Maling List List-Id: linux-acpi@vger.kernel.org On Tue, Apr 23, 2019 at 11:17:32AM +0200, Linus Walleij wrote: > On Fri, Apr 12, 2019 at 5:20 PM Yue Haibing wrote: > > > From: YueHaibing > > > > When building CONFIG_ACPI is not set > > gcc warn this: > > > > drivers/gpio/gpio-merrifield.c: In function mrfld_gpio_get_pinctrl_dev_name: > > drivers/gpio/gpio-merrifield.c:388:19: error: dereferencing pointer to incomplete type struct acpi_device > > put_device(&adev->dev); > > ^~ > > > > Reported-by: Hulk Robot > > Fixes:d00d2109c367 ("gpio: merrifield: Convert to use acpi_dev_get_first_match_dev()") > > Suggested-by: Andy Shevchenko > > Signed-off-by: YueHaibing > > This doesn't apply cleanly to any GPIO branch (devel or fixes) > so I assume it is supposed to be applied to the ACPI tree. > Acked-by: Linus Walleij Thanks! Rafael, can this be applied to your tree? -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECE50C43218 for ; Fri, 26 Apr 2019 12:23:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C381F2077B for ; Fri, 26 Apr 2019 12:23:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726025AbfDZMXV (ORCPT ); Fri, 26 Apr 2019 08:23:21 -0400 Received: from mga03.intel.com ([134.134.136.65]:34564 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725877AbfDZMXV (ORCPT ); Fri, 26 Apr 2019 08:23:21 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2019 05:23:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,397,1549958400"; d="scan'208";a="137676704" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga008.jf.intel.com with ESMTP; 26 Apr 2019 05:23:18 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hJzsr-0003mt-Jh; Fri, 26 Apr 2019 15:23:17 +0300 Date: Fri, 26 Apr 2019 15:23:17 +0300 From: Andy Shevchenko To: Linus Walleij Cc: Yue Haibing , Bartosz Golaszewski , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , ACPI Devel Maling List Subject: Re: [PATCH v3] gpio: merrifield: Fix build err without CONFIG_ACPI Message-ID: <20190426122317.GP9224@smile.fi.intel.com> References: <20190405142112.26592-1-yuehaibing@huawei.com> <20190412151911.12084-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Message-ID: <20190426122317.wbUcB2u_b5Oj3HvnBjD2GzPIloRBhjluKF7OOV1BLNM@z> On Tue, Apr 23, 2019 at 11:17:32AM +0200, Linus Walleij wrote: > On Fri, Apr 12, 2019 at 5:20 PM Yue Haibing wrote: > > > From: YueHaibing > > > > When building CONFIG_ACPI is not set > > gcc warn this: > > > > drivers/gpio/gpio-merrifield.c: In function mrfld_gpio_get_pinctrl_dev_name: > > drivers/gpio/gpio-merrifield.c:388:19: error: dereferencing pointer to incomplete type struct acpi_device > > put_device(&adev->dev); > > ^~ > > > > Reported-by: Hulk Robot > > Fixes:d00d2109c367 ("gpio: merrifield: Convert to use acpi_dev_get_first_match_dev()") > > Suggested-by: Andy Shevchenko > > Signed-off-by: YueHaibing > > This doesn't apply cleanly to any GPIO branch (devel or fixes) > so I assume it is supposed to be applied to the ACPI tree. > Acked-by: Linus Walleij Thanks! Rafael, can this be applied to your tree? -- With Best Regards, Andy Shevchenko