From: Will Deacon <will.deacon@arm.com>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: mark.rutland@arm.com, lorenzo.pieralisi@arm.com,
catalin.marinas@arm.com, john.garry@huawei.com,
rjw@rjwysocki.net, linuxarm@huawei.com,
linux-acpi@vger.kernel.org, sudeep.holla@arm.com,
linux-arm-kernel@lists.infradead.org, lenb@kernel.org
Subject: Re: [PATCH v2 0/5] arm64: SPE ACPI enablement
Date: Wed, 1 May 2019 15:15:06 +0100 [thread overview]
Message-ID: <20190501141506.GC27353@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <20190426220309.55654-1-jeremy.linton@arm.com>
Hi Jeremy,
On Fri, Apr 26, 2019 at 05:03:04PM -0500, Jeremy Linton wrote:
> This patch series enables the Arm Statistical Profiling
> Extension (SPE) on ACPI platforms.
>
> This is possible because ACPI 6.3 uses a previously
> reserved field in the MADT to store the SPE interrupt
> number, similarly to how the normal PMU is described.
> If a consistent valid interrupt exists across all the
> cores in the system, a platform device is registered.
> That then triggers the SPE module, which runs as normal.
>
> This version also adds the ability to parse the PPTT for
> IDENTICAL cores. We then use this to sanity check the
> single SPE device we create. This creates a bit of a
> problem with respect to the specification though. The
> specification says that its legal for multiple tree's
> to exist in the PPTT. We handle this fine, but what
> happens in the case of multiple tree's is that the lack
> of a common node with IDENTICAL set forces us to assume
> that there are multiple non IDENTICAL cores in the
> machine.
This looks good to me. Please can you respin, addressing Raphael's
outstanding concerns on the third patch?
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
catalin.marinas@arm.com, rjw@rjwysocki.net, lenb@kernel.org,
mark.rutland@arm.com, lorenzo.pieralisi@arm.com,
sudeep.holla@arm.com, linuxarm@huawei.com, john.garry@huawei.com
Subject: Re: [PATCH v2 0/5] arm64: SPE ACPI enablement
Date: Wed, 1 May 2019 15:15:06 +0100 [thread overview]
Message-ID: <20190501141506.GC27353@fuggles.cambridge.arm.com> (raw)
Message-ID: <20190501141506.7dJAA05kC9upELN-2AJiZlTDZxHtm8qIzngdalnCsTE@z> (raw)
In-Reply-To: <20190426220309.55654-1-jeremy.linton@arm.com>
Hi Jeremy,
On Fri, Apr 26, 2019 at 05:03:04PM -0500, Jeremy Linton wrote:
> This patch series enables the Arm Statistical Profiling
> Extension (SPE) on ACPI platforms.
>
> This is possible because ACPI 6.3 uses a previously
> reserved field in the MADT to store the SPE interrupt
> number, similarly to how the normal PMU is described.
> If a consistent valid interrupt exists across all the
> cores in the system, a platform device is registered.
> That then triggers the SPE module, which runs as normal.
>
> This version also adds the ability to parse the PPTT for
> IDENTICAL cores. We then use this to sanity check the
> single SPE device we create. This creates a bit of a
> problem with respect to the specification though. The
> specification says that its legal for multiple tree's
> to exist in the PPTT. We handle this fine, but what
> happens in the case of multiple tree's is that the lack
> of a common node with IDENTICAL set forces us to assume
> that there are multiple non IDENTICAL cores in the
> machine.
This looks good to me. Please can you respin, addressing Raphael's
outstanding concerns on the third patch?
Will
next prev parent reply other threads:[~2019-05-01 14:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 22:03 [PATCH v2 0/5] arm64: SPE ACPI enablement Jeremy Linton
2019-04-26 22:03 ` Jeremy Linton
2019-04-26 22:03 ` [PATCH v2 1/5] ACPI/PPTT: Trivial, Modify the case of CPU Jeremy Linton
2019-04-26 22:03 ` Jeremy Linton
2019-04-29 8:50 ` Rafael J. Wysocki
2019-04-29 8:50 ` Rafael J. Wysocki
2019-05-01 15:46 ` Jeremy Linton
2019-05-01 15:46 ` Jeremy Linton
2019-05-06 12:07 ` Rafael J. Wysocki
2019-05-06 12:07 ` Rafael J. Wysocki
2019-04-26 22:03 ` [PATCH v2 2/5] ACPI/PPTT: Add function to return ACPI 6.3 Identical tokens Jeremy Linton
2019-04-26 22:03 ` Jeremy Linton
2019-04-26 22:03 ` [PATCH v2 3/5] ACPI/PPTT: Modify node flag detection to find last IDENTICAL Jeremy Linton
2019-04-26 22:03 ` Jeremy Linton
2019-04-29 8:59 ` Rafael J. Wysocki
2019-04-29 8:59 ` Rafael J. Wysocki
2019-05-01 16:23 ` Jeremy Linton
2019-05-01 16:23 ` Jeremy Linton
2019-04-26 22:03 ` [PATCH v2 4/5] arm_pmu: acpi: spe: Add initial MADT/SPE probing Jeremy Linton
2019-04-26 22:03 ` Jeremy Linton
2019-04-26 22:03 ` [PATCH v2 5/5] perf: arm_spe: Enable ACPI/Platform automatic module loading Jeremy Linton
2019-04-26 22:03 ` Jeremy Linton
2019-05-01 14:15 ` Will Deacon [this message]
2019-05-01 14:15 ` [PATCH v2 0/5] arm64: SPE ACPI enablement Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501141506.GC27353@fuggles.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=catalin.marinas@arm.com \
--cc=jeremy.linton@arm.com \
--cc=john.garry@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox