From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BCA6C04AB6 for ; Tue, 28 May 2019 10:39:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07AA9208CB for ; Tue, 28 May 2019 10:39:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726515AbfE1Kjl (ORCPT ); Tue, 28 May 2019 06:39:41 -0400 Received: from mga02.intel.com ([134.134.136.20]:3818 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726334AbfE1Kjl (ORCPT ); Tue, 28 May 2019 06:39:41 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 May 2019 03:39:40 -0700 X-ExtLoop1: 1 Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by fmsmga001.fm.intel.com with SMTP; 28 May 2019 03:39:36 -0700 Received: by lahna (sSMTP sendmail emulation); Tue, 28 May 2019 13:39:36 +0300 Date: Tue, 28 May 2019 13:39:36 +0300 From: Mika Westerberg To: Ruslan Babayev Cc: wsa@the-dreams.de, linux@armlinux.org.uk, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, xe-linux-external@cisco.com Subject: Re: [net-next,v3 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle Message-ID: <20190528103936.GD2781@lahna.fi.intel.com> References: <20190528032213.19839-1-ruslan@babayev.com> <20190528032213.19839-2-ruslan@babayev.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190528032213.19839-2-ruslan@babayev.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, May 27, 2019 at 08:22:12PM -0700, Ruslan Babayev wrote: > This allows drivers to lookup i2c adapters on ACPI based systems similar to > of_get_i2c_adapter_by_node() with DT based systems. > > Signed-off-by: Ruslan Babayev > Cc: xe-linux-external@cisco.com > --- > drivers/i2c/i2c-core-acpi.c | 3 ++- > include/linux/i2c.h | 6 ++++++ > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c > index 272800692088..964687534754 100644 > --- a/drivers/i2c/i2c-core-acpi.c > +++ b/drivers/i2c/i2c-core-acpi.c > @@ -337,7 +337,7 @@ static int i2c_acpi_find_match_device(struct device *dev, void *data) > return ACPI_COMPANION(dev) == data; > } > > -static struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle) > +struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle) > { > struct device *dev; > > @@ -345,6 +345,7 @@ static struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle) > i2c_acpi_find_match_adapter); > return dev ? i2c_verify_adapter(dev) : NULL; > } > +EXPORT_SYMBOL_GPL(i2c_acpi_find_adapter_by_handle); > > static struct i2c_client *i2c_acpi_find_client_by_adev(struct acpi_device *adev) > { > diff --git a/include/linux/i2c.h b/include/linux/i2c.h > index 1308126fc384..9808993f5fd5 100644 > --- a/include/linux/i2c.h > +++ b/include/linux/i2c.h > @@ -21,6 +21,7 @@ > #include > #include /* for Host Notify IRQ */ > #include /* for struct device_node */ > +#include /* for acpi_handle */ > #include /* for swab16 */ > #include > > @@ -981,6 +982,7 @@ bool i2c_acpi_get_i2c_resource(struct acpi_resource *ares, > u32 i2c_acpi_find_bus_speed(struct device *dev); > struct i2c_client *i2c_acpi_new_device(struct device *dev, int index, > struct i2c_board_info *info); > +struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle); > #else > static inline bool i2c_acpi_get_i2c_resource(struct acpi_resource *ares, > struct acpi_resource_i2c_serialbus **i2c) > @@ -996,6 +998,10 @@ static inline struct i2c_client *i2c_acpi_new_device(struct device *dev, > { > return NULL; > } > +static inline struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle h) You should use the same argument naming as with the non-stubbed one: static inline struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle) Anyway looks good to me, Reviewed-by: Mika Westerberg