From: Mark Brown <broonie@kernel.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-spi@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Masahisa Kojima <masahisa.kojima@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH v2] spi/acpi: enumerate all SPI slaves in the namespace
Date: Thu, 13 Jun 2019 20:14:35 +0100 [thread overview]
Message-ID: <20190613191435.GY5316@sirena.org.uk> (raw)
In-Reply-To: <CAKv+Gu8rTernjct93rsWo0X3FTp6bsV=0JvNGQr8C8OaqB1S7A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]
On Mon, Jun 03, 2019 at 05:56:00PM +0200, Ard Biesheuvel wrote:
> On Mon, 3 Jun 2019 at 13:08, Mika Westerberg
> > On Thu, May 30, 2019 at 01:16:34PM +0200, Ard Biesheuvel wrote:
> > > - status = acpi_walk_namespace(ACPI_TYPE_DEVICE, handle, 1,
> > > + status = acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
> > Would it be simpler to differentiate here between Apple and non-Apple
> > systems? Then we don't need all that special code and the above becomes:
> > depth = x86_apple_system ? 1 : SPI_ACPI_ENUMERATE_MAX_DEPTH;
> > status = acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT, depth,
> > ..
> > Probably requires a comment explaining why we do it like that, though.
> Yes, but note that both the root and the depth are different in this case.
> I'll play around with this idea, to see if it simplifies things.
Given that this works and got some testing I've applied this now, if
there's a simplification it can always be done incrementally.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-06-13 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 11:16 [PATCH v2] spi/acpi: enumerate all SPI slaves in the namespace Ard Biesheuvel
2019-06-03 11:08 ` Mika Westerberg
2019-06-03 15:56 ` Ard Biesheuvel
2019-06-13 19:14 ` Mark Brown [this message]
2019-06-09 23:44 ` Life is hard, and then you die
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613191435.GY5316@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=ard.biesheuvel@linaro.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=masahisa.kojima@linaro.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox