Re: [PATCH v2 0/5] PM: PCI/ACPI: Hibernation handling fixes

Rafael J. Wysocki
2019-07-05T09:50:43Z

On Monday, July 1, 2019 6:20:17 PM CEST Mika Westerberg wrote:
> On Mon, Jul 01, 2019 at 12:42:14PM +0200, Rafael J. Wysocki wrote:
> > Hi All,
> >
> > This series of patches addresses a few issues related to the handling of
> > hibernation in the PCI bus type and the ACPI PM domain and ACPI LPSS driver.
> >
> > The v2 addresses Hans' concerns regarding the LPSS changes.
> >
> > First of all, all of the runtime-suspended PCI devices and devices in the ACPI PM and LPSS
> > PM domains will be resumed during hibernation (first patch). This appears to be the
> > only way to avoid weird corner cases and the benefit from avoiding to resume those
> > devices during hibernation is questionable.
> >
> > That change allows the the hibernation callbacks in all of the involved subsystems to be
> > simplified (patches 2 and 3).
> >
> > Moreover, reusing bus-level suspend callbacks for the "poweroff" transition during
> > hibernation (which is the case for the ACPI PM domain and LPSS) is incorrect, so patch 4
> > fixes that.
> >
> > Finally, there are some leftover items in linux/acpi.h that can be dropped (patch 5).
>
> For the whole series,
>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>

Thanks!

Queued for 5.3 with the tags from you and Hans (I've fixed up comments in the first patch while applying it).