From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v2 5/5] at24: Support probing while off
Date: Mon, 26 Aug 2019 11:31:12 +0300 [thread overview]
Message-ID: <20190826083112.8888-6-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20190826083112.8888-1-sakari.ailus@linux.intel.com>
In certain use cases (where the chip is part of a camera module, and the
camera module is wired together with a camera privacy LED), powering on
the device during probe is undesirable. Add support for the at24 to
execute probe while being powered off. For this to happen, a hint in form
of a device property is required from the firmware.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/misc/eeprom/at24.c | 31 +++++++++++++++++++++----------
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 518945b2f7374..a56cd6a6105c0 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -565,6 +565,7 @@ static int at24_probe(struct i2c_client *client)
bool i2c_fn_i2c, i2c_fn_block;
unsigned int i, num_addresses;
struct at24_data *at24;
+ bool low_power;
struct regmap *regmap;
bool writable;
u8 test_byte;
@@ -702,19 +703,24 @@ static int at24_probe(struct i2c_client *client)
i2c_set_clientdata(client, at24);
- /* enable runtime pm */
- pm_runtime_set_active(dev);
+ low_power = acpi_dev_low_power_state_probe(&client->dev);
+ if (!low_power)
+ pm_runtime_set_active(dev);
+
pm_runtime_enable(dev);
/*
- * Perform a one-byte test read to verify that the
- * chip is functional.
+ * Perform a one-byte test read to verify that the chip is functional,
+ * unless powering on the device is to be avoided during probe (i.e.
+ * it's powered off right now).
*/
- err = at24_read(at24, 0, &test_byte, 1);
- pm_runtime_idle(dev);
- if (err) {
- pm_runtime_disable(dev);
- return -ENODEV;
+ if (!low_power) {
+ err = at24_read(at24, 0, &test_byte, 1);
+ pm_runtime_idle(dev);
+ if (err) {
+ pm_runtime_disable(dev);
+ return -ENODEV;
+ }
}
dev_info(dev, "%u byte %s EEPROM, %s, %u bytes/write\n",
@@ -726,8 +732,12 @@ static int at24_probe(struct i2c_client *client)
static int at24_remove(struct i2c_client *client)
{
+ bool low_power;
+
pm_runtime_disable(&client->dev);
- pm_runtime_set_suspended(&client->dev);
+ low_power = acpi_dev_low_power_state_probe(&client->dev);
+ if (!low_power)
+ pm_runtime_set_suspended(&client->dev);
return 0;
}
@@ -735,6 +745,7 @@ static int at24_remove(struct i2c_client *client)
static struct i2c_driver at24_driver = {
.driver = {
.name = "at24",
+ .probe_low_power = true,
.of_match_table = at24_of_match,
.acpi_match_table = ACPI_PTR(at24_acpi_ids),
},
--
2.20.1
prev parent reply other threads:[~2019-08-26 8:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 8:31 [PATCH v2 0/5] Support running driver's probe for a device powered off Sakari Ailus
2019-08-26 8:31 ` [PATCH v2 1/5] ACPI: Enable driver and firmware hints to control power at probe time Sakari Ailus
2019-08-26 8:43 ` Greg Kroah-Hartman
2019-08-26 10:32 ` Sakari Ailus
2019-08-26 13:34 ` Greg Kroah-Hartman
2019-08-26 13:51 ` Sakari Ailus
2019-08-28 8:55 ` Rafael J. Wysocki
2019-08-28 9:57 ` Sakari Ailus
2019-08-28 12:35 ` Rafael J. Wysocki
2019-08-26 8:46 ` Greg Kroah-Hartman
2019-08-26 10:29 ` Sakari Ailus
2019-08-26 8:31 ` [PATCH v2 2/5] ACPI: Add a convenience function to tell a device is suspended in probe Sakari Ailus
2019-08-26 8:31 ` [PATCH v2 3/5] ov5670: Support probe whilst the device is in a low power state Sakari Ailus
2019-08-26 8:31 ` [PATCH v2 4/5] media: i2c: imx319: Support probe while the device is off Sakari Ailus
2019-08-26 8:31 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826083112.8888-6-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox