From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CAD1ECE587 for ; Tue, 1 Oct 2019 13:04:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0713F205C9 for ; Tue, 1 Oct 2019 13:04:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387885AbfJANEt (ORCPT ); Tue, 1 Oct 2019 09:04:49 -0400 Received: from mga04.intel.com ([192.55.52.120]:53174 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732272AbfJANEt (ORCPT ); Tue, 1 Oct 2019 09:04:49 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2019 06:04:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,571,1559545200"; d="scan'208";a="203225613" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002.jf.intel.com with ESMTP; 01 Oct 2019 06:04:44 -0700 Received: from andy by smile with local (Exim 4.92.2) (envelope-from ) id 1iFHpb-0000ZP-1D; Tue, 01 Oct 2019 16:04:43 +0300 Date: Tue, 1 Oct 2019 16:04:43 +0300 From: Andy Shevchenko To: Adrian Hunter Cc: Joerg Roedel , iommu@lists.linux-foundation.org, Ulf Hansson , linux-mmc@vger.kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 5/6] mmc: sdhci-acpi: Switch to use acpi_dev_hid_uid_match() Message-ID: <20191001130443.GN32742@smile.fi.intel.com> References: <20190924193739.86133-1-andriy.shevchenko@linux.intel.com> <20190924193739.86133-6-andriy.shevchenko@linux.intel.com> <77ce4e34-6692-e54e-0f2f-6b8829d1e9f5@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77ce4e34-6692-e54e-0f2f-6b8829d1e9f5@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Oct 01, 2019 at 03:37:08PM +0300, Adrian Hunter wrote: > On 24/09/19 10:37 PM, Andy Shevchenko wrote: > > Since we have a generic helper, drop custom implementation in the driver. > > - if (strcmp(hid, "QCOM8051")) > > + if (acpi_dev_hid_uid_match(adev, "QCOM8051", NULL)) > > Logic is inverted Good catch! I forgot to double check it here while below it's okay... > > - if (strcmp(hid, "QCOM8051")) > > + if (!acpi_dev_hid_uid_match(adev, "QCOM8051", NULL)) -- With Best Regards, Andy Shevchenko