From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEAEFCA9EAF for ; Mon, 21 Oct 2019 13:23:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8C2A214AE for ; Mon, 21 Oct 2019 13:23:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728826AbfJUNXs (ORCPT ); Mon, 21 Oct 2019 09:23:48 -0400 Received: from mga12.intel.com ([192.55.52.136]:24504 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727256AbfJUNXr (ORCPT ); Mon, 21 Oct 2019 09:23:47 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Oct 2019 06:23:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,323,1566889200"; d="scan'208";a="196106820" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga008.fm.intel.com with ESMTP; 21 Oct 2019 06:23:45 -0700 Received: from andy by smile with local (Exim 4.92.2) (envelope-from ) id 1iMXez-00052V-6L; Mon, 21 Oct 2019 16:23:45 +0300 Date: Mon, 21 Oct 2019 16:23:45 +0300 From: Andy Shevchenko To: Hans de Goede Cc: Mika Westerberg , Bartosz Golaszewski , Linus Walleij , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH] gpiolib: acpi: Print pin number on acpi_gpiochip_alloc_event errors Message-ID: <20191021132345.GT32742@smile.fi.intel.com> References: <20191018195208.94405-1-hdegoede@redhat.com> <20191021091124.GK32742@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Oct 21, 2019 at 02:52:13PM +0200, Hans de Goede wrote: > On 21-10-2019 11:11, Andy Shevchenko wrote: > > On Fri, Oct 18, 2019 at 09:52:08PM +0200, Hans de Goede wrote: > > > Print pin number on acpi_gpiochip_alloc_event errors, to help debugging > > > these. > > > > I'm not sure which one is better decimal or hex, perhaps Mika can help me, in any case > > They are listed as hex in the dis-assembled DSTD. Oh, now I noticed the potential issue. The pin can be 16-bit, you pring here only for the case when we have evname. Maybe do something similar in these messages? Print event name for pin inside byte range and value otherwise? -- With Best Regards, Andy Shevchenko