Re: [PATCH 05/12] ACPICA: make acpi_load_table() return table index

Andy Shevchenko
2019-10-25T08:19:54Z

On Thu, Oct 24, 2019 at 11:55:49AM -0700, Erik Schmauss wrote:
> From: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
>
> ACPICA commit d1716a829d19be23277d9157c575a03b9abb7457
>
> For unloading an ACPI table, it is necessary to provide the index of
> the table. The method intended for dynamically loading or hotplug
> addition of tables, acpi_load_table(), should provide this information
> via an optional pointer to the loaded table index.
>
> This patch fixes the table unload function of acpi_configfs.
>

Thank you!

My comments below.

First of all, can I be Cc'ed to all series to be able to test?

> Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Fixes: d06c47e3dd07f ("ACPI: configfs: Resolve objects on host-directed
> table loads")

I believe this has to be one line.

> --- a/drivers/acpi/acpi_configfs.c
> +++ b/drivers/acpi/acpi_configfs.c
> @@ -53,7 +53,7 @@ static ssize_t acpi_table_aml_write(struct config_item *cfg,
> if (!table->header)
> return -ENOMEM;
>
> - ret = acpi_load_table(table->header);
> + ret = acpi_load_table(table->header, &table->index);
> if (ret) {
> kfree(table->header);
> table->header = NULL;

As far as I understood the release notes of latest ACPICA there is also a
counterpart function being provided. That said, we need to modify ConfigFS
removing path to use the new API.

Am I correct?

--
With Best Regards,
Andy Shevchenko