Re: [PATCH v2 3/3] pinctrl: cherryview: Pass irqchip when adding gpiochip

Andy Shevchenko
2019-11-06T16:17:58Z

On Wed, Nov 06, 2019 at 06:16:22PM +0200, Andy Shevchenko wrote:
> On Wed, Nov 06, 2019 at 04:47:15PM +0100, Hans de Goede wrote:
> > We need to convert all old gpio irqchips to pass the irqchip
> > setup along when adding the gpio_chip. For more info see
> > drivers/gpio/TODO.
> >
> > For chained irqchips this is a pretty straight-forward conversion.
>
> > + chip->irq.chip = &pctrl->irqchip;
>
> > + if (pctrl->need_valid_mask)
> > + chip->irq.init_valid_mask = chv_init_irq_valid_mask;
>
> I just realize we probably may assign here unconditionally

Continuing...

>
> > + chip->irq.init_hw = chv_gpio_irq_init_hw;
> > + chip->irq.parent_handler = chv_gpio_irq_handler;
> > + chip->irq.num_parents = 1;
> > + chip->irq.parents = &pctrl->irq;
> > + chip->irq.default_type = IRQ_TYPE_NONE;
> > + chip->irq.handler = handle_bad_irq;
> >
> > if (!pctrl->need_valid_mask) {

And here turn it back to NULL and check the pointer against NULL instead of
additional variable.

What do you think?

--
With Best Regards,
Andy Shevchenko