From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6484DC47E49 for ; Wed, 6 Nov 2019 16:17:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 398982178F for ; Wed, 6 Nov 2019 16:17:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727824AbfKFQR5 (ORCPT ); Wed, 6 Nov 2019 11:17:57 -0500 Received: from mga04.intel.com ([192.55.52.120]:7547 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727244AbfKFQR5 (ORCPT ); Wed, 6 Nov 2019 11:17:57 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 08:17:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,275,1569308400"; d="scan'208";a="205377635" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003.jf.intel.com with ESMTP; 06 Nov 2019 08:17:54 -0800 Received: from andy by smile with local (Exim 4.93-RC1) (envelope-from ) id 1iSO0H-0005rh-K9; Wed, 06 Nov 2019 18:17:53 +0200 Date: Wed, 6 Nov 2019 18:17:53 +0200 From: Andy Shevchenko To: Hans de Goede Cc: Mika Westerberg , Bartosz Golaszewski , Linus Walleij , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 3/3] pinctrl: cherryview: Pass irqchip when adding gpiochip Message-ID: <20191106161753.GN32742@smile.fi.intel.com> References: <20191106154715.155596-1-hdegoede@redhat.com> <20191106154715.155596-4-hdegoede@redhat.com> <20191106161622.GM32742@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191106161622.GM32742@smile.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Nov 06, 2019 at 06:16:22PM +0200, Andy Shevchenko wrote: > On Wed, Nov 06, 2019 at 04:47:15PM +0100, Hans de Goede wrote: > > We need to convert all old gpio irqchips to pass the irqchip > > setup along when adding the gpio_chip. For more info see > > drivers/gpio/TODO. > > > > For chained irqchips this is a pretty straight-forward conversion. > > > + chip->irq.chip = &pctrl->irqchip; > > > + if (pctrl->need_valid_mask) > > + chip->irq.init_valid_mask = chv_init_irq_valid_mask; > > I just realize we probably may assign here unconditionally Continuing... > > > + chip->irq.init_hw = chv_gpio_irq_init_hw; > > + chip->irq.parent_handler = chv_gpio_irq_handler; > > + chip->irq.num_parents = 1; > > + chip->irq.parents = &pctrl->irq; > > + chip->irq.default_type = IRQ_TYPE_NONE; > > + chip->irq.handler = handle_bad_irq; > > > > if (!pctrl->need_valid_mask) { And here turn it back to NULL and check the pointer against NULL instead of additional variable. What do you think? -- With Best Regards, Andy Shevchenko