Re: [RFC PATCH] apei/ghes: fix ghes_poll_func by registering in non-deferrable mode

Robert Richter
2020-01-07T13:04:44Z

On 07.01.20 16:33:24, Bhaskar Upadhaya wrote:
> On Mon, Jan 6, 2020 at 6:39 PM Borislav Petkov <bp@alien8.de> wrote:
> >
> > On Mon, Jan 06, 2020 at 04:33:19PM +0530, Bhaskar Upadhaya wrote:
> > > Definition of poll interval as per spec (referred ACPI 6.3):
> > > "Indicates the poll interval in milliseconds OSPM should use to
> > > periodically check the error source for the presence of an error
> > > condition."
> >
> > Please add that...
> >
> > > We are observing an issue in our ThunderX2 platforms wherein
> > > ghes_poll_func is not called within poll interval when timer is
> > > configured with TIMER_DEFERRABLE flag(For NO_HZ kernel) and hence we
> > > are losing the error records.
> >
> > ... and that to your commit message then, so that it is crystal clear
> > *why* you're making this change.
>
> Thanks Borislav, I will edit the commit message with you comments in
> the next patch.
> Can I get your Ack in the next patch ?

I guess Boris will apply the patch to his tree as maintainer, so no
need to ack it.

-Robert