From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BD90C2BA83 for ; Wed, 12 Feb 2020 15:36:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF76B21D7D for ; Wed, 12 Feb 2020 15:36:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727957AbgBLPgh (ORCPT ); Wed, 12 Feb 2020 10:36:37 -0500 Received: from foss.arm.com ([217.140.110.172]:34220 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727531AbgBLPgh (ORCPT ); Wed, 12 Feb 2020 10:36:37 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A1F61FEC; Wed, 12 Feb 2020 07:36:36 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BD3A13F68F; Wed, 12 Feb 2020 07:36:35 -0800 (PST) Date: Wed, 12 Feb 2020 15:36:33 +0000 From: Sudeep Holla To: Jeremy Linton Cc: John Garry , "Guohanjun (Hanjun Guo)" , ACPI Devel Maling List , "liuqi (BA)" , Sudeep Holla Subject: Re: About PPTT find_acpi_cpu_topology_package() Message-ID: <20200212153633.GD36981@bogus> References: <7a888a84-d4c5-2b49-05f3-29876d49cae6@huawei.com> <20200212115945.GA36981@bogus> <20200212135551.GB36981@bogus> <0edb6aa9-c96f-71c1-a3ab-a95df4c07317@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0edb6aa9-c96f-71c1-a3ab-a95df4c07317@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Feb 11, 2020 at 12:49:17PM -0600, Jeremy Linton wrote: > Hi, > > On 2/12/20 7:55 AM, Sudeep Holla wrote: > > On Wed, Feb 12, 2020 at 12:48:33PM +0000, John Garry wrote: > > > On 12/02/2020 11:59, Sudeep Holla wrote: > > > > [...] > > > > > > Yes, as mentioned above. We are not going to do extra work for lazy firmware. > > > > > > I don't think it's reasonable to just label this as lazy. The table may just > > > not have the flag set unintentionally. FW and software guys make mistakes, > > > like the mistakes in PPTT, itself. > > > > > > > We are not talking about flags, it's UID and it is pretty important if > > there are more than one objects of same time. > > But, this hints at my reservations with this approach. If you wanted to have > your processors numbered 0...x and your sockets numbered 0...y, there could > be overlap in the processor container objects, which should also be avoided. > Of course yes, UID needs to be unique at a given processor/container level. Yes, it's more restricted in that way compared to objects of similar type. Here they are all same processor containers, but need to enumerate from 0 at each level. -- Regards, Sudeep