From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
Marc Lehmann <schmorp@schmorp.de>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH resend 2/3] gpiolib: acpi: Rename honor_wakeup option to ignore_wake, add extra quirk
Date: Mon, 2 Mar 2020 11:30:38 +0200 [thread overview]
Message-ID: <20200302093038.GN1224808@smile.fi.intel.com> (raw)
In-Reply-To: <ac38ee83-5edf-2ee0-8cec-a0b4367054a8@redhat.com>
On Sat, Feb 29, 2020 at 09:57:52PM +0100, Hans de Goede wrote:
> On 2/28/20 12:22 PM, Hans de Goede wrote:
> > On 2/25/20 1:57 PM, Andy Shevchenko wrote:
> > > On Tue, Feb 25, 2020 at 02:34:25PM +0200, Andy Shevchenko wrote:
> > > > On Tue, Feb 25, 2020 at 12:26:04PM +0100, Hans de Goede wrote:
> > >
> > > > Let's do it as a list of pairs, but in slightly different format (I see some
> > > > potential to derive a generic parser, based on users described in
> > > > Documentation/admin-guide/kernel-parameters.txt), i.e.
> > > >
> > > > ignore_wake=pin:controller[,pin:controller[,...]]
> > >
> > > Another possible format
> > >
> > > ignore_wake=controller@pin[;controller@pin[;...]]
> >
> > I like this one, the other one with the pin first feels wrong, the pin is
> > part of the controller, not the other way around.
> >
> > I will rework the patch series to use the ignore_wake=controller@pin format.
>
> Just a quick note. I've changed the separator from ; to , for some reason
> grub, at least as used in Fedora with Fedora's grub2 BLS (boot loader spec)
> implementation does not like it when there is a ; in the kernel commandline.
Hmm... I think it would be harder then to have less possible formats in the
command line. Do you really need right now several pins to be listed?
If it's about testing, perhaps we may do it with other means.
> I will also send an email about this to Fedora grub maintainer, but for
> now it is easiest to just avoid the problem.
It's definitely bug in Grub due to existing kernel users with such format.
It means Grub is unable to support kernel command line in full.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-03-02 9:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 10:27 [PATCH resend 1/3] gpiolib: acpi: ignore-wakeup handling rework Hans de Goede
2020-02-25 10:27 ` [PATCH resend 1/3] gpiolib: acpi: Correct comment for HP x2 10 honor_wakeup quirk Hans de Goede
2020-02-25 10:27 ` [PATCH resend 2/3] gpiolib: acpi: Rename honor_wakeup option to ignore_wake, add extra quirk Hans de Goede
2020-02-25 10:54 ` Andy Shevchenko
2020-02-25 11:26 ` Hans de Goede
2020-02-25 12:34 ` Andy Shevchenko
2020-02-25 12:57 ` Andy Shevchenko
2020-02-28 11:22 ` Hans de Goede
2020-02-28 13:16 ` Andy Shevchenko
2020-02-29 20:57 ` Hans de Goede
2020-03-02 9:30 ` Andy Shevchenko [this message]
2020-03-02 9:46 ` Hans de Goede
2020-03-02 10:57 ` Andy Shevchenko
2020-02-25 10:27 ` [PATCH resend 3/3] gpiolib: acpi: Add quirk to ignore EC gpio wakeups for 1 more HP x2 10 model Hans de Goede
2020-02-25 10:28 ` [PATCH resend 1/3] gpiolib: acpi: ignore-wakeup handling rework Hans de Goede
2020-02-28 22:54 ` Linus Walleij
2020-02-29 18:14 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302093038.GN1224808@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=schmorp@schmorp.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox