Re: [patch 02/22] x86/cpu: Add conistent CPU match macros

Thomas Gleixner
2020-03-20T20:28:25Z

Andy Shevchenko <andy.shevchenko@gmail.com> writes:
>
>> Also a add a few model constants for Centaur CPUs and QUARK.
>
> I would perhaps made this as a separate change(s).

Can do.

>> +#define X86_MATCH_VENDOR_FAM_MODEL_FEATURE(_vendor, _family, _model, \
>> + _feature, _data) { \
>
> I would leave it on one line despite the length, but it's up to you.
>
>> + .vendor = X86_VENDOR_##_vendor, \
>> + .family = _family, \
>> + .model = _model, \
>> + .feature = _feature, \
>
>> + .driver_data = (unsigned long) _data \
>
> For sake of consistency shouldn't be this kernel_ulong_t ?

I can change that though in kernel space this does not matter.

> Or we are going to get rid of that type?

No.

Thanks,

tglx