Re: [patch 01/22] x86/devicetable: Move x86 specific macro out of generic code

Andy Shevchenko
2020-03-20T14:33:28Z

On Fri, Mar 20, 2020 at 3:17 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> There is no reason that this gunk is in a generic header file. The wildcard
> defines need to stay as they are required by file2alias.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> arch/x86/include/asm/cpu_device_id.h | 13 ++++++++++++-
> arch/x86/kvm/svm.c | 1 +
> arch/x86/kvm/vmx/vmx.c | 1 +
> drivers/cpufreq/acpi-cpufreq.c | 1 +
> drivers/cpufreq/amd_freq_sensitivity.c | 1 +
> include/linux/mod_devicetable.h | 4 +---
> 6 files changed, 17 insertions(+), 4 deletions(-)
>
> --- a/arch/x86/include/asm/cpu_device_id.h
> +++ b/arch/x86/include/asm/cpu_device_id.h
> @@ -6,10 +6,21 @@
> * Declare drivers belonging to specific x86 CPUs
> * Similar in spirit to pci_device_id and related PCI functions
> */

> -

Seems you are going to remove below anyway in the next patches, so,
why not to do this also there?

> #include <linux/mod_devicetable.h>

--
With Best Regards,
Andy Shevchenko