Re: [patch 02/22] x86/cpu: Add conistent CPU match macros

Bjorn Helgaas
2020-03-20T14:29:16Z

s/conistent/consistent/ in subject

On Fri, Mar 20, 2020 at 02:13:47PM +0100, Thomas Gleixner wrote:
> Finding all places which build x86_cpu_id match tables is tedious and the
> logic is hidden in lots of differently named macro wrappers.
>
> Most of these initializer macros use plain C89 initializers which rely on
> the ordering of the struct members. So new members could only be added at
> the end of the struct, but that's ugly as hell and C99 initializers are
> really the right thing to use.
>
> Provide a set of macros which:
>
> - Have a proper naming scheme, starting with X86_MATCH_
>
> - Use C99 initializers
>
> The set of provided macros are all subsets of the base macro
>
> X86_MATCH_VENDOR_FAM_MODEL_FEATURE()
>
> which allows to supply all possible selection criteria:
>
> vendor, family, model, feature
>
> The other macros shorten this to avoid typing all arguments when they are
> not needed and would require one of the _ANY constants. They have been
> created due to the requirements of the existing usage sites.
>
> Also a add a few model constants for Centaur CPUs and QUARK.

s/Also a/Also/