From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Bjorn Helgaas <bhelgaas@google.com>, <linux-pci@vger.kernel.org>
Cc: <linux-acpi@vger.kernel.org>, <linuxarm@huawei.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: [PATCH 1/2] PCI/AER: Do not reset the device status if doing firmware first handling.
Date: Fri, 22 May 2020 01:31:33 +0800 [thread overview]
Message-ID: <20200521173134.2456773-2-Jonathan.Cameron@huawei.com> (raw)
In-Reply-To: <20200521173134.2456773-1-Jonathan.Cameron@huawei.com>
pci_aer_clear_device_status() currently resets the device status even when
firmware first handling is going on. In particular it resets it on the
root port.
This has been discussed previously
https://lore.kernel.org/patchwork/patch/427375/.
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
drivers/pci/pcie/aer.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index f4274d301235..43e78b97ace6 100644
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -373,6 +373,9 @@ void pci_aer_clear_device_status(struct pci_dev *dev)
{
u16 sta;
+ if (pcie_aer_get_firmware_first(dev))
+ return;
+
pcie_capability_read_word(dev, PCI_EXP_DEVSTA, &sta);
pcie_capability_write_word(dev, PCI_EXP_DEVSTA, sta);
}
--
2.19.1
next prev parent reply other threads:[~2020-05-21 17:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 17:31 [RFC PATCH 0/2] PCI/AER: handling for RCiEPs Jonathan Cameron
2020-05-21 17:31 ` Jonathan Cameron [this message]
2020-06-16 17:47 ` [PATCH 1/2] PCI/AER: Do not reset the device status if doing firmware first handling Bjorn Helgaas
2020-06-16 18:00 ` Kuppuswamy, Sathyanarayanan
2020-06-17 9:31 ` Jonathan Cameron
2020-06-17 20:57 ` Kuppuswamy, Sathyanarayanan
2020-06-17 9:18 ` Jonathan Cameron
2020-05-21 17:31 ` [PATCH 2/2] PCI/AER: Add partial initial support for RCiEPs using RCEC or firmware first Jonathan Cameron
2020-06-16 10:47 ` [RFC PATCH 0/2] PCI/AER: handling for RCiEPs Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521173134.2456773-2-Jonathan.Cameron@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox