Re: [PATCH v1 3/5] gpio: pca953x: Drop unneeded ACPI_PTR()

Andy Shevchenko
2020-05-25T17:58:19Z

On Thu, May 21, 2020 at 12:19:14AM +0300, Andy Shevchenko wrote:
> ACPI_PTR() becomes a no-op when !CONFIG_ACPI. This is not needed since
> we always have ID table enabled. Moreover, in the mentioned case compiler
> will complain about defined but not used variable.

Bart, are you going to apply this one, or should I resend it as a part of v2?

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/gpio/gpio-pca953x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 4bb3d3524bc7..1fca8dd7824f 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -1176,7 +1176,7 @@ static struct i2c_driver pca953x_driver = {
> .name = "pca953x",
> .pm = &pca953x_pm_ops,
> .of_match_table = pca953x_dt_ids,
> - .acpi_match_table = ACPI_PTR(pca953x_acpi_ids),
> + .acpi_match_table = pca953x_acpi_ids,
> },
> .probe = pca953x_probe,
> .remove = pca953x_remove,
> --
> 2.26.2
>

--
With Best Regards,
Andy Shevchenko