From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 358A6C433DF for ; Thu, 18 Jun 2020 08:36:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 132DF214DB for ; Thu, 18 Jun 2020 08:36:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592469419; bh=ceL/T8t0nvr/U3tOjodwMKknS/aAxNJ8RojCHrLF1ok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=VnuIhG8EPLalPqYgH4Leef7tgw7oblR2W8cmW6y+8s3/sAkO4GJi1eo+HdnLuvhfO ceow4kK8BjXvlOmhWGOUQ9DRZoYa0ukAHITqjcx5XRInoV2Pj1JJJBz4WDjLaff99H ekUkhnOEk9d21rK7lbKaxaDwqYVM2+kmHUCWNybM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728615AbgFRIg6 (ORCPT ); Thu, 18 Jun 2020 04:36:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:54142 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728585AbgFRIgy (ORCPT ); Thu, 18 Jun 2020 04:36:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EBE5F214DB; Thu, 18 Jun 2020 08:36:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592469413; bh=ceL/T8t0nvr/U3tOjodwMKknS/aAxNJ8RojCHrLF1ok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fhmVqgBm4oYl3kaigyXF+fjYbAtWBnSCDQ01zfS0JLYK3gukCSKFX5/7FuhT1Rddg G+/nRvmR+h/ih67DEse6ah3ZJOIHmQNa/IrfpIzNqOgVLauwcJ4gL8gLuByIeLnTZe XbWo06NX2QYRQYvzI3OU8jnZRnrWl3CjgdK+X07A= Date: Thu, 18 Jun 2020 10:36:46 +0200 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: Rajat Jain , Christoph Hellwig , David Woodhouse , Lu Baolu , Joerg Roedel , Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown , iommu@lists.linux-foundation.org, Linux Kernel Mailing List , linux-pci , ACPI Devel Maling List , Raj Ashok , "Krishnakumar, Lalithambika" , Mika Westerberg , Jean-Philippe Brucker , Prashant Malani , Benson Leung , Todd Broch , Alex Levin , Mattias Nissler , Rajat Jain , Bernie Keany , Aaron Durbin , Diego Rivas , Duncan Laurie , Furquan Shaikh , Jesse Barnes , Christian Kellner , Alex Williamson , Oliver O'Halloran Subject: Re: [PATCH 4/4] pci: export untrusted attribute in sysfs Message-ID: <20200618083646.GA1066967@kroah.com> References: <20200616011742.138975-1-rajatja@google.com> <20200616011742.138975-4-rajatja@google.com> <20200616073249.GB30385@infradead.org> <20200617073100.GA14424@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Jun 18, 2020 at 11:12:56AM +0300, Andy Shevchenko wrote: > On Wed, Jun 17, 2020 at 10:56 PM Rajat Jain wrote: > > On Wed, Jun 17, 2020 at 12:31 AM Christoph Hellwig wrote: > > ... > > > (and likely call it "external" instead of "untrusted". > > Which is not okay. 'External' to what? 'untrusted' has been carefully > chosen by the meaning of it. > What external does mean for M.2. WWAN card in my laptop? It's in ACPI > tables, but I can replace it. Then your ACPI tables should show this, there is an attribute for it, right? > This is only one example. Or if firmware of some device is altered, > and it's internal (whatever it means) is it trusted or not? That is what people are using policy for today, if you object to this, please bring it up to those developers :) > So, please leave it as is (I mean name). firmware today exports this attribute, why do you not want userspace to also know it? Trust is different, yes, don't get the two mixed up please. That should be a different sysfs attribute for obvious reasons. thanks, greg k-h