From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32F9BC433DF for ; Mon, 6 Jul 2020 18:48:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11581207BB for ; Mon, 6 Jul 2020 18:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594061337; bh=TmzFSzpXz/IVyxhzyFOMQr63SdCmzzt9hF2zFcEfusA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=I0/40Anx97rcZllCt+vgo227+aozTHSNQUoj+0FzzGbm2cHzvb/fPS666sKX+LPq3 pLBC3Rfq9VSEHuA+8IXppbZeVUQJhmHJVkwyvDZ6V5UM8NJZlLVAszpbsHk+d60+dn 5027LC6dxJWJ4aBYC0MZc64rT2jOuW1RiYGkAA+4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729745AbgGFSs4 (ORCPT ); Mon, 6 Jul 2020 14:48:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:42452 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729569AbgGFSs4 (ORCPT ); Mon, 6 Jul 2020 14:48:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 44B6A20773; Mon, 6 Jul 2020 18:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594061336; bh=TmzFSzpXz/IVyxhzyFOMQr63SdCmzzt9hF2zFcEfusA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T+FtnLgdUY+221uDBs5Ha8exDMqail3b7n8Jia7lbUoHBH/GyyUX5isSnxbdpDMfl mVA69kh3JU6+46LL4UY7kQ3nrwbAPSFmEZtZE9KDoUTV9TdouG4oB4qeEehE9HG4mH LXwLsGTCgO/ih+UHSnsrlItO5tNGvguXMDwGK2tk= Date: Mon, 6 Jul 2020 20:48:55 +0200 From: Greg Kroah-Hartman To: Bjorn Helgaas Cc: Rajat Jain , David Woodhouse , Lu Baolu , Joerg Roedel , Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, Raj Ashok , lalithambika.krishnakumar@intel.com, Mika Westerberg , Jean-Philippe Brucker , Prashant Malani , Benson Leung , Todd Broch , Alex Levin , Mattias Nissler , Rajat Jain , Bernie Keany , Aaron Durbin , Diego Rivas , Duncan Laurie , Furquan Shaikh , Jesse Barnes , Christian Kellner , Alex Williamson , oohall@gmail.com, Saravana Kannan , Suzuki K Poulose , Arnd Bergmann , Heikki Krogerus Subject: Re: [PATCH v2 2/7] PCI: Set "untrusted" flag for truly external devices only Message-ID: <20200706184855.GA2335741@kroah.com> References: <20200630075554.GA619174@kroah.com> <20200706164126.GA124329@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200706164126.GA124329@bjorn-Precision-5520> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Jul 06, 2020 at 11:41:26AM -0500, Bjorn Helgaas wrote: > On Tue, Jun 30, 2020 at 09:55:54AM +0200, Greg Kroah-Hartman wrote: > > On Mon, Jun 29, 2020 at 09:49:38PM -0700, Rajat Jain wrote: > > > The "ExternalFacing" devices (root ports) are still internal devices that > > > sit on the internal system fabric and thus trusted. Currently they were > > > being marked untrusted. > > > > > > This patch uses the platform flag to identify the external facing devices > > > and then use it to mark any downstream devices as "untrusted". The > > > external-facing devices themselves are left as "trusted". This was > > > discussed here: https://lkml.org/lkml/2020/6/10/1049 > > > > {sigh} > > > > First off, please use lore.kernel.org links, we don't control lkml.org > > and it often times has been down. > > > > Also, you need to put all of the information in the changelog, referring > > to another place isn't always the best thing, considering you will be > > looking this up in 20+ years to try to figure out why people came up > > with such a crazy design. > > > > But, the main point is, no, we did not decide on this. "trust" is a > > policy decision to make by userspace, it is independant of "location", > > while you are tieing it directly here, which is what I explicitly said > > NOT to do. > > > > So again, no, I will NAK this patch as-is, sorry, you are mixing things > > together in a way that it should not do at this point in time. > > What do you see being mixed together here? I acknowledge that the > name of "pdev->untrusted" is probably a mistake. But this patch > doesn't change anything there. It only changes the treatment of the > edge case of the "ExternalFacing" ports. Previously we treated them > as being external themselves, which does seem wrong. I don't see the patch here, and it's been a while but I think there is a mixture of "location" and "trust" happening here with a single value when they should be separate. Hopefully the next round of this patch series will be better. thanks, greg k-h