From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 311EAC433E1 for ; Fri, 24 Jul 2020 16:47:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D23420674 for ; Fri, 24 Jul 2020 16:47:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bPgwX0Xl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726667AbgGXQrm (ORCPT ); Fri, 24 Jul 2020 12:47:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726878AbgGXQrm (ORCPT ); Fri, 24 Jul 2020 12:47:42 -0400 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2ED1C0619D3; Fri, 24 Jul 2020 09:47:41 -0700 (PDT) Received: by mail-ed1-x544.google.com with SMTP id i26so4173755edv.4; Fri, 24 Jul 2020 09:47:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zzDKwcg9p8gnVKAmDaaJM93RupDzTADuoLrwrIiJ8S4=; b=bPgwX0Xlb6utFBvmWrYYwjprckvrVERzxB/WKnvCXwUUhJ8YFDnVd6d9kC6FcO+9NP 17po36U4aKHtFDQfFNtOVk+FaL81aZocyB3PKtmxwZNEYufKoc6xw48d1uQur6wd9wg2 AbYQTzsIlDdjzKmY1DonVOijtFz9XdE8eL8k5U97zvNky+hFRXG3XkQvaehXjxdTSbLw u9vth+lr2Tl4gKpWRH1oue84tZjYGa0x52nwGE9/lhe7J1l8eS04p0/gIv2BEXhtTxSe kC7b+ahKrFRSp0uVgaRvSXPiRgMZk4QsjuL1Mx7Da+aAkaKz2VO6UwUHEEBnPH/zg1th qrCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zzDKwcg9p8gnVKAmDaaJM93RupDzTADuoLrwrIiJ8S4=; b=rFBhEOpwSDUoeNFRCVjjDWHO4h/IjjKEMa0q1F2w9+AaI7NDzQhEsRbXntaWEyDf40 AqEEP1y2LIlYoKEjufcsg1Puaty51dB/0izoNOee2OBZb2V+rIpFpXOfT3qrGqs6FdzO ePhzSa2Pp7Nuu6976mQ3zTQH0vjeDHTzIIQy2EvgZZuksGGh/ExAfnaAa8DOsLQSFyTP GDh02tWqPZY/UVhd5ftBnlGz+J7aCvDA7c8m1BRX2shuKeqz2ceD0fbU2om5HtnJ/1Fw SwhkOaZIUgpQQDqpqcm7WKaXgFkacsVXU7h20RcUOigBxL7AMPo2g36PQy7FiL+T0JH2 OGLw== X-Gm-Message-State: AOAM530QZfxWXlkBkJkftm4JPiSxccGs0xmGIQT40yYe3Pky0/buKisg G7f7rsgS1gZTAAYj+rBnngY= X-Google-Smtp-Source: ABdhPJw5uXA1NchHuOQ0mFITGNMD2Vb66pBvlCEfZz3Q6x+IfZbiNwlhpyFK18GzcKkCaNx3ZUPaUw== X-Received: by 2002:aa7:d989:: with SMTP id u9mr9684898eds.85.1595609260520; Fri, 24 Jul 2020 09:47:40 -0700 (PDT) Received: from garrit-VirtualBox ([94.31.102.44]) by smtp.gmail.com with ESMTPSA id u19sm1112193edd.62.2020.07.24.09.47.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 09:47:40 -0700 (PDT) Date: Fri, 24 Jul 2020 18:47:38 +0200 From: Garrit Franke To: "Moore, Robert" Cc: "Wysocki, Rafael J" , "lenb@kernel.org" , "trivial@kernel.org" , "linux-acpi@vger.kernel.org" , "devel@acpica.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH] trivial: acpi: replace some bitshifts with BIT macro Message-Id: <20200724184738.ce10d8db0bbe138e2b24f7a6@gmail.com> In-Reply-To: References: <20200724162050.18077-2-garritfranke@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, 24 Jul 2020 16:29:14 +0000 "Moore, Robert" wrote: > Where is "BIT" defined? It is defined in multiple places (see include/vdso/bits.h for example), therefore I blatently assumed that it would be defined. I'm quite new to kernel development, and I'm learning along the way. Thank you for pointing this out. Would it make sense to copy this file to this drivers root, or is it not worth the effort? Thanks for your time Garrit