public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 1/7] resource: Simplify region_intersects() by reducing conditionals
Date: Thu, 13 Aug 2020 20:57:23 +0300	[thread overview]
Message-ID: <20200813175729.15088-1-andriy.shevchenko@linux.intel.com> (raw)

Now we have for 'other' and 'type' variables

other	type	return
  0	  0	REGION_DISJOINT
  0	  x	REGION_INTERSECTS
  x	  0	REGION_DISJOINT
  x	  x	REGION_MIXED

Obviously it's easier to check 'type' for 0 first instead of
currently checked 'other'.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 kernel/resource.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/kernel/resource.c b/kernel/resource.c
index 841737bbda9e..70575a61bf20 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -554,13 +554,10 @@ int region_intersects(resource_size_t start, size_t size, unsigned long flags,
 	}
 	read_unlock(&resource_lock);
 
-	if (other == 0)
-		return type ? REGION_INTERSECTS : REGION_DISJOINT;
+	if (type == 0)
+		return REGION_DISJOINT;
 
-	if (type)
-		return REGION_MIXED;
-
-	return REGION_DISJOINT;
+	return (other == 0) ? REGION_INTERSECTS : REGION_MIXED;
 }
 EXPORT_SYMBOL_GPL(region_intersects);
 
-- 
2.28.0


             reply	other threads:[~2020-08-13 17:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-13 17:57 Andy Shevchenko [this message]
2020-08-13 17:57 ` [PATCH v1 2/7] resource: Group resource_overlaps() with other inline helpers Andy Shevchenko
2020-08-14 15:18   ` Rafael J. Wysocki
2020-08-14 15:37     ` Andy Shevchenko
2020-08-13 17:57 ` [PATCH v1 3/7] resource: Introduce resource_union() for overlapping resources Andy Shevchenko
2020-08-14 15:23   ` Rafael J. Wysocki
2020-08-14 15:37     ` Andy Shevchenko
2020-08-14 16:09       ` Rafael J. Wysocki
2020-08-14 16:21         ` Andy Shevchenko
2020-08-14 17:17           ` Rafael J. Wysocki
2020-08-14 17:43             ` Andy Shevchenko
2020-08-13 17:57 ` [PATCH v1 4/7] resource: Introduce resource_intersection() " Andy Shevchenko
2020-08-14 15:24   ` Rafael J. Wysocki
2020-08-14 15:38     ` Andy Shevchenko
2020-08-13 17:57 ` [PATCH v1 5/7] PCI/ACPI: Replace open coded variant of resource_union() Andy Shevchenko
2020-08-14 15:26   ` Rafael J. Wysocki
2020-08-13 17:57 ` [PATCH v1 6/7] PCI/ACPI: Fix description of @handle for acpi_is_root_bridge() Andy Shevchenko
2020-08-14 15:11   ` Rafael J. Wysocki
2020-08-14 15:18     ` Andy Shevchenko
2020-08-13 17:57 ` [PATCH v1 7/7] ACPI: watchdog: Replace open coded variant of resource_union() Andy Shevchenko
2020-08-14 15:27   ` Rafael J. Wysocki
2020-08-14 15:17 ` [PATCH v1 1/7] resource: Simplify region_intersects() by reducing conditionals Rafael J. Wysocki
2020-08-14 15:39   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200813175729.15088-1-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox