From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v1 1/7] resource: Simplify region_intersects() by reducing conditionals
Date: Fri, 14 Aug 2020 18:39:21 +0300 [thread overview]
Message-ID: <20200814153921.GT1891694@smile.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0hF7CJYQJsvGbPCr+1Rfi_QqeMkT4z3MrGfmB00CdQvyA@mail.gmail.com>
On Fri, Aug 14, 2020 at 05:17:22PM +0200, Rafael J. Wysocki wrote:
> On Thu, Aug 13, 2020 at 7:57 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Now we have for 'other' and 'type' variables
> >
> > other type return
> > 0 0 REGION_DISJOINT
> > 0 x REGION_INTERSECTS
> > x 0 REGION_DISJOINT
> > x x REGION_MIXED
> >
> > Obviously it's easier to check 'type' for 0 first instead of
> > currently checked 'other'.
...
> > + return (other == 0) ? REGION_INTERSECTS : REGION_MIXED;
>
> The parens are not needed here.
Right.
> Also I would do
>
> if (other == 0)
> REGION_INTERSECTS;
>
> return REGION_MIXED;
Works for me, I'll update in v2.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-08-14 15:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 17:57 [PATCH v1 1/7] resource: Simplify region_intersects() by reducing conditionals Andy Shevchenko
2020-08-13 17:57 ` [PATCH v1 2/7] resource: Group resource_overlaps() with other inline helpers Andy Shevchenko
2020-08-14 15:18 ` Rafael J. Wysocki
2020-08-14 15:37 ` Andy Shevchenko
2020-08-13 17:57 ` [PATCH v1 3/7] resource: Introduce resource_union() for overlapping resources Andy Shevchenko
2020-08-14 15:23 ` Rafael J. Wysocki
2020-08-14 15:37 ` Andy Shevchenko
2020-08-14 16:09 ` Rafael J. Wysocki
2020-08-14 16:21 ` Andy Shevchenko
2020-08-14 17:17 ` Rafael J. Wysocki
2020-08-14 17:43 ` Andy Shevchenko
2020-08-13 17:57 ` [PATCH v1 4/7] resource: Introduce resource_intersection() " Andy Shevchenko
2020-08-14 15:24 ` Rafael J. Wysocki
2020-08-14 15:38 ` Andy Shevchenko
2020-08-13 17:57 ` [PATCH v1 5/7] PCI/ACPI: Replace open coded variant of resource_union() Andy Shevchenko
2020-08-14 15:26 ` Rafael J. Wysocki
2020-08-13 17:57 ` [PATCH v1 6/7] PCI/ACPI: Fix description of @handle for acpi_is_root_bridge() Andy Shevchenko
2020-08-14 15:11 ` Rafael J. Wysocki
2020-08-14 15:18 ` Andy Shevchenko
2020-08-13 17:57 ` [PATCH v1 7/7] ACPI: watchdog: Replace open coded variant of resource_union() Andy Shevchenko
2020-08-14 15:27 ` Rafael J. Wysocki
2020-08-14 15:17 ` [PATCH v1 1/7] resource: Simplify region_intersects() by reducing conditionals Rafael J. Wysocki
2020-08-14 15:39 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814153921.GT1891694@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox