From: Borislav Petkov <bp@alien8.de>
To: Shiju Jose <shiju.jose@huawei.com>
Cc: linux-edac@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, tony.luck@intel.com,
rjw@rjwysocki.net, james.morse@arm.com, lenb@kernel.org,
linuxarm@huawei.com
Subject: Re: [PATCH 1/1] RAS: Add CPU Correctable Error Collector to isolate an erroneous CPU core
Date: Tue, 1 Sep 2020 16:35:39 +0200 [thread overview]
Message-ID: <20200901143539.GC8392@zn.tnic> (raw)
In-Reply-To: <20200901140140.1772-1-shiju.jose@huawei.com>
On Tue, Sep 01, 2020 at 03:01:40PM +0100, Shiju Jose wrote:
> When the CPU correctable errors reported on an ARM64 CPU core too often,
> it should be isolated. Add the CPU correctable error collector to
> store the CPU correctable error count.
>
> When the correctable error count for a CPU exceed the threshold
> value in a short time period, it will try to isolate the CPU core.
> The threshold value, time period etc are configurable.
>
> Implementation details is added in the file.
>
> Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
> ---
> Documentation/ABI/testing/debugfs-cpu-cec | 22 ++
> arch/arm64/ras/Kconfig | 8 +
> drivers/acpi/apei/ghes.c | 30 +-
> drivers/ras/Kconfig | 1 +
> drivers/ras/Makefile | 1 +
> drivers/ras/cpu_cec.c | 393 ++++++++++++++++++++++
So instead of adding the ability to collect other error types to the
CEC, you're duplicating the CEC itself?!
Why?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-09-01 14:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 14:01 [PATCH 1/1] RAS: Add CPU Correctable Error Collector to isolate an erroneous CPU core Shiju Jose
2020-09-01 14:35 ` Borislav Petkov [this message]
2020-09-01 16:20 ` Shiju Jose
2020-09-09 12:02 ` Borislav Petkov
2020-09-10 15:29 ` Shiju Jose
2020-09-17 8:40 ` Borislav Petkov
2020-10-01 17:16 ` James Morse
2020-10-01 17:30 ` Borislav Petkov
2020-10-02 12:23 ` Shiju Jose
2020-09-01 18:51 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901143539.GC8392@zn.tnic \
--to=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=rjw@rjwysocki.net \
--cc=shiju.jose@huawei.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox