[PATCH] ACPI: video: use ACPI backlight for HP 635 Notebook

[PATCH] ACPI: video: use ACPI backlight for HP 635 Notebook

[Alex Hung]

Default backlight interface is AMD's radeon_bl0 which does not work on
this system. As a result, let's for ACPI backlight interface for this
system.

BugLink: https://bugs.launchpad.net/bugs/1894667

Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 drivers/acpi/video_detect.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 2499d7e..05047a3 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -282,6 +282,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "530U4E/540U4E"),
 		},
 	},
+	/* https://bugs.launchpad.net/bugs/1894667 */
+	{
+	 .callback = video_detect_force_video,
+	 .ident = "HP 635 Notebook",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "HP 635 Notebook PC"),
+		},
+	},
 
 	/* Non win8 machines which need native backlight nevertheless */
 	{
-- 
2.7.4

Re: [PATCH] ACPI: video: use ACPI backlight for HP 635 Notebook

[Greg KH]

On Fri, Sep 11, 2020 at 04:14:20PM -0600, Alex Hung wrote:
> Default backlight interface is AMD's radeon_bl0 which does not work on
> this system. As a result, let's for ACPI backlight interface for this
> system.
> 
> BugLink: https://bugs.launchpad.net/bugs/1894667
> 
> Cc: All applicable <stable@vger.kernel.org>
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  drivers/acpi/video_detect.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index 2499d7e..05047a3 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -282,6 +282,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>  		DMI_MATCH(DMI_PRODUCT_NAME, "530U4E/540U4E"),
>  		},
>  	},
> +	/* https://bugs.launchpad.net/bugs/1894667 */
> +	{
> +	 .callback = video_detect_force_video,
> +	 .ident = "HP 635 Notebook",
> +	 .matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "HP 635 Notebook PC"),
> +		},
> +	},
>  
>  	/* Non win8 machines which need native backlight nevertheless */
>  	{
> -- 
> 2.7.4
> 

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

Re: [PATCH] ACPI: video: use ACPI backlight for HP 635 Notebook

[Alex Hung]

On 2020-09-12 12:49 a.m., Greg KH wrote:
> On Fri, Sep 11, 2020 at 04:14:20PM -0600, Alex Hung wrote:
>> Default backlight interface is AMD's radeon_bl0 which does not work on
>> this system. As a result, let's for ACPI backlight interface for this
>> system.
>>
>> BugLink: https://bugs.launchpad.net/bugs/1894667
>>
>> Cc: All applicable <stable@vger.kernel.org>
>> Signed-off-by: Alex Hung <alex.hung@canonical.com>
>> ---
>>  drivers/acpi/video_detect.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
>> index 2499d7e..05047a3 100644
>> --- a/drivers/acpi/video_detect.c
>> +++ b/drivers/acpi/video_detect.c
>> @@ -282,6 +282,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>>  		DMI_MATCH(DMI_PRODUCT_NAME, "530U4E/540U4E"),
>>  		},
>>  	},
>> +	/* https://bugs.launchpad.net/bugs/1894667 */
>> +	{
>> +	 .callback = video_detect_force_video,
>> +	 .ident = "HP 635 Notebook",
>> +	 .matches = {
>> +		DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
>> +		DMI_MATCH(DMI_PRODUCT_NAME, "HP 635 Notebook PC"),
>> +		},
>> +	},
>>  
>>  	/* Non win8 machines which need native backlight nevertheless */
>>  	{
>> -- 
>> 2.7.4
>>
> 
> <formletter>
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read:
>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
> 
> </formletter>
> 

Sorry about this.

I will send V2 to correct it to "Cc: stable@vger.kernel.org"


-- 
Cheers,
Alex Hung