From: Borislav Petkov <bp@alien8.de>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: linux-mm@kvack.org, linux-acpi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, x86@kernel.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
rafael@kernel.org, Ingo Molnar <mingo@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
linuxarm@huawei.com, Dan Williams <dan.j.williams@intel.com>,
Brice Goglin <Brice.Goglin@inria.fr>,
Sean V Kelley <sean.v.kelley@linux.intel.com>,
linux-api@vger.kernel.org, Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [PATCH v11 2/6] x86: Support Generic Initiator only proximity domains
Date: Mon, 28 Sep 2020 19:35:13 +0200 [thread overview]
Message-ID: <20200928173513.GG1685@zn.tnic> (raw)
In-Reply-To: <20200928125235.446188-3-Jonathan.Cameron@huawei.com>
On Mon, Sep 28, 2020 at 08:52:31PM +0800, Jonathan Cameron wrote:
> In common with memoryless domains we only register GI domains
^^^^
> if the proximity node is not online. If a domain is already
> a memory containing domain, or a memoryless domain there is
> nothing to do just because it also contains a Generic Initiator.
...
> +/*
> + * A node may exist which has one or more Generic Initiators but no CPUs and no
> + * memory.
> + *
> + * This function must be called after init_cpu_to_node() to ensure that we have
^^^
You love that "we". :)
Pls use passive voice in your commit message: no "we" or "I", etc, and
describe your changes in imperative mood.
Also, pls read section "2) Describe your changes" in
Documentation/process/submitting-patches.rst for more details.
Bottom line is: personal pronouns are ambiguous in text, especially with
so many parties/companies/etc developing the kernel so let's avoid them
please.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-09-28 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 12:52 [PATCH v11 0/6] ACPI: Support Generic Initiator proximity domains Jonathan Cameron
2020-09-28 12:52 ` [PATCH v11 1/6] ACPI: Support Generic Initiator only domains Jonathan Cameron
2020-09-28 12:52 ` [PATCH v11 2/6] x86: Support Generic Initiator only proximity domains Jonathan Cameron
2020-09-28 17:35 ` Borislav Petkov [this message]
2020-09-28 12:52 ` [PATCH v11 3/6] ACPI: Let ACPI know we support Generic Initiator Affinity Structures Jonathan Cameron
2020-09-28 12:52 ` [PATCH v11 4/6] ACPI: HMAT: Fix handling of changes from ACPI 6.2 to ACPI 6.3 Jonathan Cameron
2020-09-28 12:52 ` [PATCH v11 5/6] node: Add access1 class to represent CPU to memory characteristics Jonathan Cameron
2020-09-28 12:52 ` [PATCH v11 6/6] docs: mm: numaperf.rst Add brief description for access class 1 Jonathan Cameron
2020-09-28 19:26 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928173513.GG1685@zn.tnic \
--to=bp@alien8.de \
--cc=Brice.Goglin@inria.fr \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=guohanjun@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=sean.v.kelley@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox